Re: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-25 Thread kbuild test robot
Hi Vicentiu, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vicentiu-Galanopulo/net-phy-Enable-C45-vendor-specific-MDIO-register-addr-space/20180418-014927 config: x86_64-randconfig-b0-04260315

Re: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-18 Thread Andrew Lunn
On Wed, Apr 18, 2018 at 09:38:47AM +, Vicenţiu Galanopulo wrote: > > > > > Having dev-addr stored in devices_addrs, in get_phy_c45_ids(), when > > > probing the identifiers, dev-addr can be extracted from devices_addrs > > > and probed if devices_addrs[current_identifier] is not 0. > > > >

RE: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-18 Thread Vicenţiu Galanopulo
> > Having dev-addr stored in devices_addrs, in get_phy_c45_ids(), when > > probing the identifiers, dev-addr can be extracted from devices_addrs > > and probed if devices_addrs[current_identifier] is not 0. > > I must clearly be missing something, but why are you introducing all these >

Re: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-17 Thread Florian Fainelli
On 04/17/2018 02:02 AM, Vicentiu Galanopulo wrote: > A search of the dev-addr property is done in of_mdiobus_register. > If the property is found in the PHY node, of_mdiobus_register_vend_spec_phy() > is called. This is a wrapper function for of_mdiobus_register_phy() > which finds the device in

Re: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-17 Thread Andrew Lunn
On Tue, Apr 17, 2018 at 04:02:33AM -0500, Vicentiu Galanopulo wrote: > A search of the dev-addr property is done in of_mdiobus_register. > If the property is found in the PHY node, of_mdiobus_register_vend_spec_phy() > is called. This is a wrapper function for of_mdiobus_register_phy() > which

[PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-17 Thread Vicentiu Galanopulo
A search of the dev-addr property is done in of_mdiobus_register. If the property is found in the PHY node, of_mdiobus_register_vend_spec_phy() is called. This is a wrapper function for of_mdiobus_register_phy() which finds the device in package based on dev-addr, and fills devices_addrs, which is