Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

2016-06-10 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Another possible approach would have been to allocate the vlan structure > upong port_vlan_prepare() though that would typically result in more > fragmentation over time once se start using more VLANs. This is indeed what the

Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

2016-06-10 Thread Andrew Lunn
On Fri, Jun 10, 2016 at 11:47:48AM -0700, Florian Fainelli wrote: > On 06/10/2016 05:00 AM, Andrew Lunn wrote: > >> @@ -148,6 +155,9 @@ struct bcm_sf2_priv { > >>struct device_node *master_mii_dn; > >>struct mii_bus *slave_mii_bus; > >>struct mii_bus

Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

2016-06-10 Thread Florian Fainelli
On 06/10/2016 05:00 AM, Andrew Lunn wrote: >> @@ -148,6 +155,9 @@ struct bcm_sf2_priv { >> struct device_node *master_mii_dn; >> struct mii_bus *slave_mii_bus; >> struct mii_bus *master_mii_bus; >> + >> +/* Cache of programmed VLANs

Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

2016-06-10 Thread Andrew Lunn
> @@ -148,6 +155,9 @@ struct bcm_sf2_priv { > struct device_node *master_mii_dn; > struct mii_bus *slave_mii_bus; > struct mii_bus *master_mii_bus; > + > + /* Cache of programmed VLANs */ > + struct bcm_sf2_vlan

[PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

2016-06-09 Thread Florian Fainelli
Add support for configuring VLANs on the Broadcom Starfigther2 switch. This is all done through the bridge vlan facility just like other DSA drivers. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 266 +-