RE: [PATCH net-next 5/5] net: mvpp2: jumbo frames support

2018-03-04 Thread Stefan Chulski
> > To perform checksum in HW, HW obviously should work in store and > forward mode. Store all frame in TX FIFO and then check checksum. > > If mtu 1500B, everything fine and all port can do this. > > > > If mtu is 9KB and 9KB frame transmitted, Port 0 still can do HW checksum. > But ports 1 and 2

Re: [PATCH net-next 5/5] net: mvpp2: jumbo frames support

2018-03-04 Thread Thomas Petazzoni
Hello, On Sun, 4 Mar 2018 06:56:02 +, Stefan Chulski wrote: > > > + if (port->pool_long->id == MVPP2_BM_JUMBO && port->id != 0) { > > > > Again, all over the place we hardcode the fact that Jumbo frames can only be > > used on port 0. I know port 0 is the only one that can do 10G, but are

RE: [PATCH net-next 5/5] net: mvpp2: jumbo frames support

2018-03-03 Thread Stefan Chulski
> > netdev_err(port->dev, "Invalid pool %d\n", pool); > > return NULL; > > } > > @@ -4596,11 +4604,24 @@ mvpp2_bm_pool_use(struct mvpp2_port > *port, int > > pool, int pkt_size) static int mvpp2_swf_bm_pool_init(struct > > mvpp2_port *port) { > > int rxq; > > +

Re: [PATCH net-next 5/5] net: mvpp2: jumbo frames support

2018-03-02 Thread Thomas Petazzoni
Hello, On Fri, 2 Mar 2018 16:40:44 +0100, Antoine Tenart wrote: > /* Attach long pool to rxq */ > @@ -4551,7 +4559,7 @@ mvpp2_bm_pool_use(struct mvpp2_port *port, int pool, > int pkt_size) > struct mvpp2_bm_pool *new_pool = >priv->bm_pools[pool]; > int num; > > - if (pool <

[PATCH net-next 5/5] net: mvpp2: jumbo frames support

2018-03-02 Thread Antoine Tenart
From: Stefan Chulski This patch adds the support for jumbo frames in the Marvell PPv2 driver. A third buffer pool is added with 10KB buffers, which is used if the MTU is higher than 1518B for packets larger than 1518B. Please note only the port 0 supports hardware checksum