RE: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-29 Thread Brandon Streiff
> From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, September 28, 2017 1:01 PM > > > With the write and read acquiring and then releasing the lock > > immediately, is no there room for this sequence to be interrupted in the > > middle and end-up returning inconsistent reads? > > The

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Vivien Didelot
Hi Brandon, >> Would there be any value in implementing a proper gpiochip structure >> here such that other pieces of SW can see this GPIO controller as a >> provider and you can reference it from e.g: Device Tree using GPIO >> descriptors? > > That would be my preference as well, or maybe a

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 10:45:03AM -0700, Florian Fainelli wrote: > On 09/28/2017 08:25 AM, Brandon Streiff wrote: > > The Scratch/Misc register is a windowed interface that provides access > > to the GPIO configuration. Provide a new method for configuration of > > GPIO functions. > > > >

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > The Scratch/Misc register is a windowed interface that provides access > to the GPIO configuration. Provide a new method for configuration of > GPIO functions. > > Signed-off-by: Brandon Streiff > --- > +/* Offset 0x1A:

[PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Brandon Streiff
The Scratch/Misc register is a windowed interface that provides access to the GPIO configuration. Provide a new method for configuration of GPIO functions. Signed-off-by: Brandon Streiff --- drivers/net/dsa/mv88e6xxx/chip.c| 13 +++