Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-18 Thread Jiri Pirko
Wed, Aug 17, 2016 at 12:36:10PM CEST, had...@mellanox.com wrote: >Early in the datapath skb_vlan_untag function is called, stripped >the vlan from the skb and set skb->vlan_tci and skb->vlan_proto fields. > >The current dissection doesn't handle stripped vlan packets correctly. >In some flows,

Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-18 Thread Jiri Pirko
Thu, Aug 18, 2016 at 08:22:49AM CEST, had...@dev.mellanox.co.il wrote: >On Wed, Aug 17, 2016 at 4:02 PM, Jiri Pirko wrote: >> Wed, Aug 17, 2016 at 01:05:33PM CEST, had...@dev.mellanox.co.il wrote: >>>On Wed, Aug 17, 2016 at 1:46 PM, Jiri Pirko wrote: Wed,

Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-18 Thread Hadar Hen Zion
On Wed, Aug 17, 2016 at 4:02 PM, Jiri Pirko wrote: > Wed, Aug 17, 2016 at 01:05:33PM CEST, had...@dev.mellanox.co.il wrote: >>On Wed, Aug 17, 2016 at 1:46 PM, Jiri Pirko wrote: >>> Wed, Aug 17, 2016 at 12:36:10PM CEST, had...@mellanox.com wrote: Early in

Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-17 Thread Jiri Pirko
Wed, Aug 17, 2016 at 01:05:33PM CEST, had...@dev.mellanox.co.il wrote: >On Wed, Aug 17, 2016 at 1:46 PM, Jiri Pirko wrote: >> Wed, Aug 17, 2016 at 12:36:10PM CEST, had...@mellanox.com wrote: >>>Early in the datapath skb_vlan_untag function is called, stripped >>>the vlan from

Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-17 Thread Hadar Hen Zion
On Wed, Aug 17, 2016 at 1:46 PM, Jiri Pirko wrote: > Wed, Aug 17, 2016 at 12:36:10PM CEST, had...@mellanox.com wrote: >>Early in the datapath skb_vlan_untag function is called, stripped >>the vlan from the skb and set skb->vlan_tci and skb->vlan_proto fields. >> >>The current

Re: [PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-17 Thread Jiri Pirko
Wed, Aug 17, 2016 at 12:36:10PM CEST, had...@mellanox.com wrote: >Early in the datapath skb_vlan_untag function is called, stripped >the vlan from the skb and set skb->vlan_tci and skb->vlan_proto fields. > >The current dissection doesn't handle stripped vlan packets correctly. >In some flows,

[PATCH net-next V2 1/5] flow_dissector: For stripped vlan, get vlan info from skb->vlan_tci

2016-08-17 Thread Hadar Hen Zion
Early in the datapath skb_vlan_untag function is called, stripped the vlan from the skb and set skb->vlan_tci and skb->vlan_proto fields. The current dissection doesn't handle stripped vlan packets correctly. In some flows, vlan doesn't exist in skb->data anymore when applying flow dissection on