Re: [PATCH net-next WIP] ethtool: generic netlink policy

2016-04-12 Thread Johannes Berg
Hi, > + [ETHTOOL_ATTR_FLAGS]= { .type = NLA_U32 }, I suppose this comes from the current API, but perhaps it'd be worthwhile to make provision for more flags? Perhaps even using NLA_BINARY and have "infinitely extensible" flags. > + [ETHTOOL_ATTR_SSET_COUNT] =

[PATCH net-next WIP] ethtool: generic netlink policy

2016-04-10 Thread Roopa Prabhu
From: Roopa Prabhu netlink for ethtool came up at netconf/netdev and we had promised to send some of the ethtool netlink code we have. We use a generic netlink channel for ethtool between our kernel and user space driver. This ethtool channel nicely wraps most ethtool