Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-27 Thread Kirill Tkhai
On 26.03.2018 21:36, J. Bruce Fields wrote: > On Fri, Mar 23, 2018 at 02:53:34PM -0400, Anna Schumaker wrote: >> >> >> On 03/13/2018 06:49 AM, Kirill Tkhai wrote: >>> These pernet_operations initialize and destroy sunrpc_net_id refered >>> per-net items. Only used global list is cache_list, and acc

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-26 Thread J. Bruce Fields
On Fri, Mar 23, 2018 at 02:53:34PM -0400, Anna Schumaker wrote: > > > On 03/13/2018 06:49 AM, Kirill Tkhai wrote: > > These pernet_operations initialize and destroy sunrpc_net_id refered > > per-net items. Only used global list is cache_list, and accesses > > already serialized. > > > > sunrpc_d

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-26 Thread Kirill Tkhai
On 23.03.2018 21:53, Anna Schumaker wrote: > > > On 03/13/2018 06:49 AM, Kirill Tkhai wrote: >> These pernet_operations initialize and destroy sunrpc_net_id >> refered per-net items. Only used global list is cache_list, >> and accesses already serialized. >> >> sunrpc_destroy_cache_detail() check

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-23 Thread Anna Schumaker
On 03/13/2018 06:49 AM, Kirill Tkhai wrote: > These pernet_operations initialize and destroy sunrpc_net_id > refered per-net items. Only used global list is cache_list, > and accesses already serialized. > > sunrpc_destroy_cache_detail() check for list_empty() without > cache_list_lock, but when

Re: [PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-23 Thread Anna Schumaker
On 03/13/2018 06:49 AM, Kirill Tkhai wrote: > These pernet_operations initialize and destroy sunrpc_net_id > refered per-net items. Only used global list is cache_list, > and accesses already serialized. > > sunrpc_destroy_cache_detail() check for list_empty() without > cache_list_lock, but when

[PATCH net-next nfs 1/6] net: Convert rpcsec_gss_net_ops

2018-03-13 Thread Kirill Tkhai
These pernet_operations initialize and destroy sunrpc_net_id refered per-net items. Only used global list is cache_list, and accesses already serialized. sunrpc_destroy_cache_detail() check for list_empty() without cache_list_lock, but when it's called from unregister_pernet_subsys(), there can't