Re: [PATCH net-next resubmit 2/2] net: phy: core: don't disable device interrupts in phy_change

2017-12-04 Thread David Miller
From: Heiner Kallweit Date: Thu, 30 Nov 2017 23:57:00 +0100 > If state is not PHY_HALTED I see no need to temporarily disable > interrupts on the device. As long as the current interrupt isn't acked > on the device no new interrupt can happen anyway. > > In addition remove a unneeded enabling of

[PATCH net-next resubmit 2/2] net: phy: core: don't disable device interrupts in phy_change

2017-11-30 Thread Heiner Kallweit
If state is not PHY_HALTED I see no need to temporarily disable interrupts on the device. As long as the current interrupt isn't acked on the device no new interrupt can happen anyway. In addition remove a unneeded enabling of interrupts in the state machine when handling state PHY_CHANGELINK. Te