Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-17 Thread Richard Alpe
On 2015-09-16 18:19, Nikolay Aleksandrov wrote: > The root cause is use of res.table uninitialized. >> >> Thanks to Nikolay for noticing the uninitialized use amongst the maze of >> gotos. >> >> As Nikolay pointed out the second initialization is not required to fix >> the oops, but rather to

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-17 Thread David Miller
From: David Ahern Date: Wed, 16 Sep 2015 10:16:39 -0600 > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: ... > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use

[PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread David Ahern
Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., from Richard: [0.877040] BUG: unable to handle kernel NULL pointer dereference at 0056 [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 [0.877597] PGD 3fa14067 PUD 3fa6e067 PMD 0 [0.877597]

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Nikolay Aleksandrov
On 09/16/2015 06:16 PM, David Ahern wrote: > Sergey, Richard and Fabio reported an oops in ip_route_input_noref. e.g., > from Richard: > > [0.877040] BUG: unable to handle kernel NULL pointer dereference at > 0056 > [0.877597] IP: [] ip_route_input_noref+0x1a2/0xb00 > [

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Florian Fainelli
On 16/09/15 09:16, David Ahern wrote: > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > As Nikolay pointed out the second initialization is not required to fix > the oops, but rather to fix a related

Re: [PATCH net-next v2] net: Initialize table in fib result

2015-09-16 Thread Sergey Senozhatsky
On (09/16/15 10:16), David Ahern wrote: [..] > The root cause is use of res.table uninitialized. > > Thanks to Nikolay for noticing the uninitialized use amongst the maze of > gotos. > > As Nikolay pointed out the second initialization is not required to fix > the oops, but rather to fix a