Re: [PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir

2017-12-08 Thread David Miller
From: Prashant Bhole Date: Fri, 8 Dec 2017 14:32:18 +0900 > Reason: > Discussion started about adding error check on return value where > it was not handled. Also handling the error using IS_ERR_OR_NULL > instead of IS_ERR(), because debugfs_create_dir() doesn't

Re: [PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir

2017-12-07 Thread Jakub Kicinski
On Fri, 8 Dec 2017 14:32:18 +0900, Prashant Bhole wrote: > Reason: > Discussion started about adding error check on return value where > it was not handled. Also handling the error using IS_ERR_OR_NULL > instead of IS_ERR(), because debugfs_create_dir() doesn't return > error. It returns NULL or

[PATCH net-next v2] netdevsim: remove return value check of debugfs_create_dir

2017-12-07 Thread Prashant Bhole
Reason: Discussion started about adding error check on return value where it was not handled. Also handling the error using IS_ERR_OR_NULL instead of IS_ERR(), because debugfs_create_dir() doesn't return error. It returns NULL or a valid pointer when DebugFS is enabled. Finally it was decided to