Re: [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

[Pavel Belous]

On 02/18/2017 02:56 PM, Lino Sanfilippo wrote:

Hi,

On 17.02.2017 22:07, Pavel Belous wrote:

From: Pavel Belous 

The following patchset contains improvements and fixes for aQuantia
AQtion ethernet driver from net-next tree.

Most fixes are based on the comments from Lino Sanfilippo.

Sanity testing was performed on real HW. No regression found.

v1->v2 :Removed buffers copying.
Fixed dma error handling.


Please review.


You could have added all "reviewed-by" tags that you have received so
far for patches in the former version of this series. I think otherwise this
information will get lost.

Regards,
Lino



I was thinking to add this tag, but i was unsure.

Thank you, I will add "Reviewed-by" tags for reviewed patches from v1 
(not changed) in patches v3.


Regards,
Pavel

Re: [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

[Lino Sanfilippo]

Hi,

On 17.02.2017 22:07, Pavel Belous wrote:
> From: Pavel Belous 
> 
> The following patchset contains improvements and fixes for aQuantia
> AQtion ethernet driver from net-next tree.
> 
> Most fixes are based on the comments from Lino Sanfilippo.
> 
> Sanity testing was performed on real HW. No regression found.
> 
> v1->v2 :Removed buffers copying.
>   Fixed dma error handling.
> 
> 
> Please review.

You could have added all "reviewed-by" tags that you have received so
far for patches in the former version of this series. I think otherwise this 
information will get lost.

Regards,
Lino

[PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes

[Pavel Belous]

From: Pavel Belous 

The following patchset contains improvements and fixes for aQuantia
AQtion ethernet driver from net-next tree.

Most fixes are based on the comments from Lino Sanfilippo.

Sanity testing was performed on real HW. No regression found.

v1->v2 :Removed buffers copying.
Fixed dma error handling.


Please review.
Thanks.
Pavel Belous (12):
  net: ethernet: aquantia: Removed extra assignment for skb->dev.
  net: ethernet: aquantia: Removed busy_count field.
  net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu ==
new_mtu".
  net: ethernet: aquantia: Using module_pci_driver.
  net: ethernet: aquantia: Superfluous initialization of "err".
  net: ethernet: aquantia: Fixed missing rtnl_unlock.
  net: ethernet: aquantia: Using NETDEV_TX_OK instead 0.
  net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.
  net: ethernet: aquantia: Call netdev_register after all initialized.
  net: ethernet: aquantia: Fixed incorrect buff->len calculation.
  net: ethernet: aquantia: Fixed memory allocation if
AQ_CFG_RX_FRAME_MAX > 1 page.
  net: ethernet: aquantia: Copying tx buffers is not needed.

 drivers/net/ethernet/aquantia/atlantic/aq_main.c   |  34 +---
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 205 +++--
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |  24 +--
 drivers/net/ethernet/aquantia/atlantic/aq_ring.h   |   3 -
 drivers/net/ethernet/aquantia/atlantic/aq_utils.h  |   1 -
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |   4 +-
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |   4 +-
 7 files changed, 122 insertions(+), 153 deletions(-)

-- 
2.7.4