Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

2018-02-12 Thread Guillaume Nault
On Mon, Feb 12, 2018 at 10:11:07AM +, James Chapman wrote: > Previously, if a tunnel was closed, we called inet_shutdown to mark > the socket as unconnected such that userspace would get errors and > then close the socket. This could race with userspace closing the > socket. Instead, leave user

Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

2018-02-12 Thread James Chapman
On 12/02/18 16:22, David Miller wrote: > From: James Chapman > Date: Mon, 12 Feb 2018 10:11:07 + > >> Previously, if a tunnel was closed, we called inet_shutdown to mark >> the socket as unconnected such that userspace would get errors and >> then close the socket. This could race with userspa

Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

2018-02-12 Thread David Miller
From: James Chapman Date: Mon, 12 Feb 2018 10:11:07 + > Previously, if a tunnel was closed, we called inet_shutdown to mark > the socket as unconnected such that userspace would get errors and > then close the socket. This could race with userspace closing the > socket. Instead, leave userspa

[PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel destroy

2018-02-12 Thread James Chapman
Previously, if a tunnel was closed, we called inet_shutdown to mark the socket as unconnected such that userspace would get errors and then close the socket. This could race with userspace closing the socket. Instead, leave userspace to close the socket in its own time (our tunnel will be detached