Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
On Mon, Aug 28, 2017 at 12:06:24PM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 28, 2017 at 11:40:51AM +0200, Antoine Tenart wrote: > > On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > > > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > > >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Russell King - ARM Linux
On Mon, Aug 28, 2017 at 11:40:51AM +0200, Antoine Tenart wrote: > On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > > >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote: > On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > > > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > > Alaska 88E1xxx series), is in-band link information always available? > > I'd

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Russell King - ARM Linux
On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote: > Hi Antoine, > > Can you be 100% sure that when using SGMII with PHY's (like Marvell > Alaska 88E1xxx series), is in-band link information always available? > I'd be very cautious with such assumption and use in-band management > only

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Marcin Wojtas
Hi Antoine, 2017-08-28 8:55 GMT+02:00 Antoine Tenart : > Hi Russell, > > On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: >> On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: >> > The link mode (speed, duplex) was forced

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-28 Thread Antoine Tenart
Hi Russell, On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: > > The link mode (speed, duplex) was forced based on what the phylib > > returns. This should not be the case, and only forced by ethtool > >

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-25 Thread Russell King - ARM Linux
On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: > The link mode (speed, duplex) was forced based on what the phylib > returns. This should not be the case, and only forced by ethtool > functions manually. This patch removes the link mode enforcement from > the phylib link_event

[PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-25 Thread Antoine Tenart
The link mode (speed, duplex) was forced based on what the phylib returns. This should not be the case, and only forced by ethtool functions manually. This patch removes the link mode enforcement from the phylib link_event callback. Signed-off-by: Antoine Tenart