Re: [PATCH net-next v2 2/7] net: dsa: mv88e6xxx: drop revision probing

2016-04-15 Thread Andrew Lunn
On Fri, Apr 15, 2016 at 07:21:23PM -0400, Vivien Didelot wrote: > There is no point in having special case for the revision when probing a > switch model. The code gets cluttered with unnecessary defines, and > leads to errors when code such as mv88e6131_setup compares > PORT_SWITCH_ID_6131_B2 to

[PATCH net-next v2 2/7] net: dsa: mv88e6xxx: drop revision probing

2016-04-15 Thread Vivien Didelot
There is no point in having special case for the revision when probing a switch model. The code gets cluttered with unnecessary defines, and leads to errors when code such as mv88e6131_setup compares PORT_SWITCH_ID_6131_B2 to ps->id which mask the revision. Drop every revision definitions, add a