Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

2015-11-23 Thread Nikolay Aleksandrov
On 11/23/2015 06:44 AM, Cong Wang wrote: > On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov > wrote: >> net/ipv4/ipmr.c | 191 >> +++- >> 1 file changed, 107 insertions(+), 84 deletions(-) > > Does this really

Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

2015-11-22 Thread Cong Wang
On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov wrote: > net/ipv4/ipmr.c | 191 > +++- > 1 file changed, 107 insertions(+), 84 deletions(-) Does this really simplify the code? :-/ -- To unsubscribe from this list:

[PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

2015-11-21 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Take rtnl in the beginning unconditionally as most options already need it (one exception - MRT_DONE, see the comment inside), make the lock/unlock places central and move out the switch() local variables. Signed-off-by: Nikolay Aleksandrov