Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-20 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > I still don't see why that would cause a hang. [ 996.37] [] mutex_lock+0x22/0x2a [ 996.38] [] mdiobus_read+0x36/0x60 [ 996.38] [] vsc85xx_config_init+0x4c/0x1e2 vsc85xx_config_init is calling mdiobus_read while holding the mdio_lock.

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andrew Lunn
On Mon, Nov 19, 2018 at 05:14:38PM +0100, Andreas Schwab wrote: > On Nov 19 2018, Andrew Lunn wrote: > > > Could you turn on lockdep and see if it reports a deadlock. > > How do I "turn on lockdep"? make menuconfig Kernel hacking Lock Debugging (spinlocks, mutexes, etc...) Lock debugging:

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > Could you turn on lockdep and see if it reports a deadlock. How do I "turn on lockdep"? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andrew Lunn
On Mon, Nov 19, 2018 at 04:50:14PM +0100, Andreas Schwab wrote: > On Nov 19 2018, Alexandre Belloni wrote: > > > My first intuition is that he mac driver quentin is using does > > phy_connect when the interface is opened while macb is doing it at probe > > time. I didn't investigate but maybe

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Alexandre Belloni wrote: > My first intuition is that he mac driver quentin is using does > phy_connect when the interface is opened while macb is doing it at probe > time. I didn't investigate but maybe this can help :) The phy probing of macb is very unreliable, perhaps it

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Alexandre Belloni
On 19/11/2018 16:28:30+0100, Andrew Lunn wrote: > On Mon, Nov 19, 2018 at 04:13:10PM +0100, Andreas Schwab wrote: > > On Nov 19 2018, Andrew Lunn wrote: > > > > > On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: > > >> On Okt 08 2018, Quentin Schulz wrote: > > >> > > >> > The

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andrew Lunn
On Mon, Nov 19, 2018 at 04:13:10PM +0100, Andreas Schwab wrote: > On Nov 19 2018, Andrew Lunn wrote: > > > On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: > >> On Okt 08 2018, Quentin Schulz wrote: > >> > >> > The Microsemi PHYs have multiple banks of registers (called pages).

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Nov 19 2018, Andrew Lunn wrote: > On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: >> On Okt 08 2018, Quentin Schulz wrote: >> >> > The Microsemi PHYs have multiple banks of registers (called pages). >> > Registers can only be accessed from one page, if we need a register

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andrew Lunn
On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: > On Okt 08 2018, Quentin Schulz wrote: > > > The Microsemi PHYs have multiple banks of registers (called pages). > > Registers can only be accessed from one page, if we need a register from > > another page, we need to switch the

Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions

2018-11-19 Thread Andreas Schwab
On Okt 08 2018, Quentin Schulz wrote: > The Microsemi PHYs have multiple banks of registers (called pages). > Registers can only be accessed from one page, if we need a register from > another page, we need to switch the page and the registers of all other > pages are not accessible anymore. > >