Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-11 Thread David Miller
From: David Ahern Date: Wed, 7 Oct 2015 08:17:39 -0700 > +static void fixup_managed_addr(struct inet6_dev *idev, struct inet6_ifaddr > *ifp) > +{ > + if (!ifp->rt) > + ifp->rt = addrconf_dst_alloc(idev, >addr, false); This potentially leaves an error

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-08 Thread Hannes Frederic Sowa
Hi David, David Ahern writes: > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: > > $ ip -6 addr add dev eth1 2000:11:1:1::1/64 > $ ip addr show dev eth1 > 3: eth1:

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-08 Thread David Ahern
Hi Hannes: On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote: diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h index 1c8b6820b694..f190a14148ab 100644 --- a/include/net/if_inet6.h +++ b/include/net/if_inet6.h @@ -72,6 +72,7 @@ struct inet6_ifaddr { int

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-08 Thread Hannes Frederic Sowa
Hi David, David Ahern writes: > On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote: >>> diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h >>> index 1c8b6820b694..f190a14148ab 100644 >>> --- a/include/net/if_inet6.h >>> +++ b/include/net/if_inet6.h >>> @@ -72,6

[PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-07 Thread David Ahern
Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr add dev eth1 2000:11:1:1::1/64 $ ip addr show dev eth1 3: eth1: mtu 1500 qdisc noop state DOWN group default qlen 1000

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-07 Thread Sowmini Varadhan
On Wed, Oct 7, 2015 at 11:17 AM, David Ahern wrote: > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: : > > Add a new sysctl to make this behavior optional. The new setting defaults to > flush all

Re: [PATCH net-next v4] net: ipv6: Make address flushing on ifdown optional

2015-10-07 Thread David Ahern
On 10/7/15 9:43 AM, Sowmini Varadhan wrote: On Wed, Oct 7, 2015 at 11:17 AM, David Ahern wrote: Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: : Add a new sysctl to make this behavior