On Thu, Dec 14, 2017 at 11:07 PM, Chopra, Manish
wrote:
> Michael, I checked it on again, I tried to set LRO in dev->features and
> dev->hw_features.
> Somehow, it gets disabled after register_netdevice(). Any idea why ?
> Although, I am not running any
<ariel.el...@cavium.com>;
> Dept-Eng Everest Linux L2 <dept-engeverestlinu...@cavium.com>
> Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.
>
> On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish
> <manish.cho...@cavium.com> wrote:
> >
> > H
On Wed, Dec 13, 2017 at 11:46 PM, Chopra, Manish
wrote:
>
> 2). In bnx2x_fix_features() we used to do before these changes -
>
> /* TPA requires Rx CSUM offloading */
> if (!(features & NETIF_F_RXCSUM)) {
> features &= ~NETIF_F_LRO;
>
<ariel.el...@cavium.com>;
> Dept-Eng Everest Linux L2 <dept-engeverestlinu...@cavium.com>
> Subject: Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.
>
> On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish
> <manish.cho...@cavium.com> wrote:
> >
> > H
On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish
wrote:
>
> Hi Michael, There seems a behavioral change here. This driver support two HW
> aggregation modes [LRO and GRO]
> With the changes, Interfaces come with HW GRO enabled and LRO disabled by
> default as opposed
Linux L2 engeverestlinu...@cavium.com>
> Subject: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.
>
> Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when
> NETIF_F_GRO_HW is set. Disable NETIF_F_GRO_HW in bnx2x_fix_features() if
> the MTU does not support TPA_MODE_GRO or
Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW
is set. Disable NETIF_F_GRO_HW in bnx2x_fix_features() if the MTU
does not support TPA_MODE_GRO or GRO is not set. bnx2x_change_mtu() also
needs to disable NETIF_F_GRO_HW if the MTU does not support it.
Cc: Ariel Elior