Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Mon, 14 May 2018 11:08:28 +0200 > >> David Miller writes: >> >>> From: Toke Høiland-Jørgensen >>> Date: Tue, 08 May 2018 16:34:19 +0200 >>> +struct cake_flow

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 14 May 2018 11:08:28 +0200 > David Miller writes: > >> From: Toke Høiland-Jørgensen >> Date: Tue, 08 May 2018 16:34:19 +0200 >> >>> +struct cake_flow { >>> + /* this stuff is all needed per-flow at

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Tue, 08 May 2018 16:34:19 +0200 > >> +struct cake_flow { >> +/* this stuff is all needed per-flow at dequeue time */ >> +struct sk_buff*head; >> +struct sk_buff*tail; > > Please do

Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-13 Thread David Miller
From: Toke Høiland-Jørgensen Date: Tue, 08 May 2018 16:34:19 +0200 > +struct cake_flow { > + /* this stuff is all needed per-flow at dequeue time */ > + struct sk_buff*head; > + struct sk_buff*tail; Please do not invent your own SKB list handling mechanism.

[PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-08 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth