Re: [PATCH net 01/13] net: sched: cls_u32: fix hnode refcounting

2018-09-09 Thread Jamal Hadi Salim
On 2018-09-08 9:31 p.m., Al Viro wrote: From: Al Viro cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references via ->hlist and via ->tp_root together. u32_destroy() drops the former and, in case when there had been links, leaves the sucker on the list. As the result, there's

[PATCH net 01/13] net: sched: cls_u32: fix hnode refcounting

2018-09-08 Thread Al Viro
From: Al Viro cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references via ->hlist and via ->tp_root together. u32_destroy() drops the former and, in case when there had been links, leaves the sucker on the list. As the result, there's nothing to protect it from getting freed