Re: [PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs()

From: Eric Dumazet Date: Thu, 26 May 2016 09:56:36 -0700 > I truly believe that every time a driver has a private flow dissector, > it always have at least one bug. +1

Re: [PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs()

On 26/05/16 17:56, Eric Dumazet wrote: > Lot of magic here. Yet another flow dissection. > > Seems to be a good place to use net/core/flow_dissector.c helpers. Fair point, but that doesn't really feel like 'net' material. I'll look into flow_dissector and see if I can get something ready for when

Re: [PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs()

On Thu, 2016-05-26 at 17:01 +0100, Edward Cree wrote: > Previously efx_filter_rfs() assumed that the headers it needed (802.1Q, IP) > would be present in the linear data area of the SKB. > When running with debugging I found that this is not always the case and > that in fact the data may all be

[PATCH net 1/2] sfc: handle nonlinear SKBs in efx_filter_rfs()

Previously efx_filter_rfs() assumed that the headers it needed (802.1Q, IP) would be present in the linear data area of the SKB. When running with debugging I found that this is not always the case and that in fact the data may all be paged. So now use skb_header_pointer() to extract the data.