Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-19 Thread David Miller
From: Alexander Aring Date: Wed, 18 Apr 2018 17:35:33 -0400 > @@ -92,12 +92,43 @@ struct meta_tlvhdr { > __be16 len; > }; > > +static inline bool __ife_tlv_meta_valid(const unsigned char *skbdata, > + const unsigned char

Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-19 Thread Jamal Hadi Salim
On 19/04/18 01:37 AM, yotam gigi wrote: On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote: There is currently no handling to check on a invalid tlv length. This patch adds such handling to avoid killing the kernel with a malformed ife packet. That's very important.

Re: [PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-18 Thread yotam gigi
On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring wrote: > There is currently no handling to check on a invalid tlv length. This > patch adds such handling to avoid killing the kernel with a malformed > ife packet. That's very important. Thanks for that! > > Signed-off-by:

[PATCH net 2/3] net: sched: ife: handle malformed tlv length

2018-04-18 Thread Alexander Aring
There is currently no handling to check on a invalid tlv length. This patch adds such handling to avoid killing the kernel with a malformed ife packet. Signed-off-by: Alexander Aring --- include/net/ife.h | 3 ++- net/ife/ife.c | 35