Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-11 Thread James Chapman
On 11/10/16 02:54, R Parameswaran wrote: > > > Hi James, > > Please see inline: > > On Tue, Oct 4, 2016 at 12:53 AM, James Chapman > wrote: > > On 04/10/16 04:12, R. Parameswaran wrote: > > > > Hi James, > > > > Please see

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-04 Thread James Chapman
On 04/10/16 04:12, R. Parameswaran wrote: > > Hi James, > > Please see inline, thanks for the reply: > > On Sat, 1 Oct 2016, James Chapman wrote: > >> On 30/09/16 03:39, R. Parameswaran wrote: > + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ > + if

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-03 Thread R. Parameswaran
Hi James, Please see inline, thanks for the reply: On Sat, 1 Oct 2016, James Chapman wrote: > On 30/09/16 03:39, R. Parameswaran wrote: > > > >>> + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ > >>> + if (tunnel->sock->sk_family == AF_INET) > >>> + overhead +=

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-01 Thread James Chapman
On 30/09/16 03:39, R. Parameswaran wrote: > >>> + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ >>> + if (tunnel->sock->sk_family == AF_INET) >>> + overhead += (ETH_HLEN + sizeof(struct iphdr)); >>> + else if (tunnel->sock->sk_family == AF_INET6) >>> +

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread R. Parameswaran
Hi James, On Thu, 29 Sep 2016, James Chapman wrote: > On 22/09/16 21:52, R. Parameswaran wrote: > > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > > From: "R. Parameswaran" > > Date: Thu, 22 Sep 2016 13:19:25 -0700 > > Subject: [PATCH]

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread James Chapman
On 29/09/16 03:36, R. Parameswaran wrote: > I agree that something like 2. below would be needed in the long run (it > will need some effort and redesign -e.g. how do I lookup the parent tunnel > from the socket when receiving a PMTU update, existing pointer chain runs > from tunnel to socket).

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread James Chapman
On 22/09/16 21:52, R. Parameswaran wrote: > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > From: "R. Parameswaran" > Date: Thu, 22 Sep 2016 13:19:25 -0700 > Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2 > > Take into account

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-29 Thread Jiri Benc
On Wed, 28 Sep 2016 19:36:45 -0700 (PDT), R. Parameswaran wrote: > I'd like to point out one difference with VXLAN - in VXLAN, the > local physical interface is directly specified at the time of > creation of the tunnel, and the data structure seems to have the ifindex > of the local interface

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-28 Thread R. Parameswaran
Hi David, Please see inline: On Wed, 28 Sep 2016, David Miller wrote: > From: "R. Parameswaran" > Date: Tue, 27 Sep 2016 12:17:21 -0700 (PDT) > > > Later, in vxlan_dev_configure(), called from vxlan_dev_create(), it gets > > adjusted to account for the headers: >

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-28 Thread David Miller
From: "R. Parameswaran" Date: Tue, 27 Sep 2016 12:17:21 -0700 (PDT) > Later, in vxlan_dev_configure(), called from vxlan_dev_create(), it gets > adjusted to account for the headers: > > vxlan_dev_configure(): > ... > if (!conf->mtu) >

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-27 Thread R. Parameswaran
Hi David, Thanks for the reply, please see inline: On Tue, 27 Sep 2016, David Miller wrote: > From: "R. Parameswaran" > Date: Thu, 22 Sep 2016 13:52:43 -0700 (PDT) > > > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > > From: "R.

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-27 Thread David Miller
From: "R. Parameswaran" Date: Thu, 22 Sep 2016 13:52:43 -0700 (PDT) > From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 > From: "R. Parameswaran" > Date: Thu, 22 Sep 2016 13:19:25 -0700 > Subject: [PATCH] L2TP:Adjust intf

[PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-22 Thread R. Parameswaran
>From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 From: "R. Parameswaran" Date: Thu, 22 Sep 2016 13:19:25 -0700 Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2 Take into account all of the tunnel encapsulation headers when setting