Re: [PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties

2018-02-12 Thread David Miller
From: Kirill Tkhai Date: Mon, 12 Feb 2018 13:10:34 +0300 > This err branch looks excess. It was before your patch, but in case of you > change this place, > can't we stop having it? it looks like we can simply do the below here: > > err = tipc_enable_bearer(net, bearer, domain, prio, attr

Re: [PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties

2018-02-12 Thread Kirill Tkhai
Hi, Ying, On 12.02.2018 11:56, Ying Xue wrote: > Currently when user changes link properties, TIPC first checks if > user's command message contains media name or bearer name through > tipc_media_find() or tipc_bearer_find() which is protected by RTNL > lock. But when tipc_nl_compat_link_set() con

[PATCH net v2] tipc: fix missing RTNL lock protection during setting link properties

2018-02-12 Thread Ying Xue
Currently when user changes link properties, TIPC first checks if user's command message contains media name or bearer name through tipc_media_find() or tipc_bearer_find() which is protected by RTNL lock. But when tipc_nl_compat_link_set() conducts the checking with the two functions, it doesn't ho