Re: [PATCH net v2 2/2] bridge: netlink: register netdevice before executing changelink

On Sat, 8 Apr 2017 14:41:59 +0300 wrote: > + err = br_changelink(dev, tb, data); > + if (err) > + goto unregister; > + > + return 0; > + > +unregister: > + unregister_netdevice(dev); > + return err; > } Why use a goto? just do: err =

[PATCH net v2 2/2] bridge: netlink: register netdevice before executing changelink

From: Ido Schimmel Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference at 0190 [13634.939436] IP: __vlan_add+0x73/0x5f0