Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 Thread Aaron Conole
Liping Zhang writes: > 2016-09-28 11:08 GMT+08:00 Liping Zhang : >> Hi Feng, >> >> 2016-09-28 9:23 GMT+08:00 Feng Gao : >>> Hi Aaraon, >>> >>> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: It's

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 Thread Feng Gao
Hi Liping, On Wed, Sep 28, 2016 at 11:13 AM, Liping Zhang wrote: > 2016-09-28 11:08 GMT+08:00 Liping Zhang : >> Hi Feng, >> >> 2016-09-28 9:23 GMT+08:00 Feng Gao : >>> Hi Aaraon, >>> >>> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Liping Zhang
2016-09-28 11:08 GMT+08:00 Liping Zhang : > Hi Feng, > > 2016-09-28 9:23 GMT+08:00 Feng Gao : >> Hi Aaraon, >> >> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >>> It's possible for nf_hook_entry_head to return NULL if two >>>

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Liping Zhang
Hi Feng, 2016-09-28 9:23 GMT+08:00 Feng Gao : > Hi Aaraon, > > On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >> It's possible for nf_hook_entry_head to return NULL if two >> nf_unregister_net_hook calls happen simultaneously with a single hook > >

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Feng Gao
Hi Aaraon, On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: > It's possible for nf_hook_entry_head to return NULL if two > nf_unregister_net_hook calls happen simultaneously with a single hook The critical region of nf_unregister_net_hook is protected by _hook_mutex.

[PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-27 Thread Aaron Conole
It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole ---