Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-23 Thread Marcelo Ricardo Leitner
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE,

Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-21 Thread Denys Vlasenko
On 06/21/2017 09:24 PM, Marcelo Ricardo Leitner wrote: On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: This function compiles to 147 bytes of machine code. 13 callsites. I'm no expert on SCTP events, but quick reading of SCTP docs tells me that SCTP events are not happening on

Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-21 Thread Marcelo Ricardo Leitner
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE,

[PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-21 Thread Denys Vlasenko
This function compiles to 147 bytes of machine code. 13 callsites. I'm no expert on SCTP events, but quick reading of SCTP docs tells me that SCTP events are not happening on every packet. They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such. Does not look performance critical.