Hi Satyam,
From: Satyam Sharma [EMAIL PROTECTED]
[8/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure
Hi Joel,
On Tue, 10 Jul 2007, Joel Becker wrote:
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote:
Hmm, I put it in there because I expected that the user must have had
at least one target configured (added to target_list) if he's got the
module loaded/built-in (and netconsole
From: Satyam Sharma [EMAIL PROTECTED]
[8/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure introduced in
On 10/07/07, Satyam Sharma [EMAIL PROTECTED] wrote:
+ /* Avoid taking lock and disabling interrupts unnecessarily */
+ if (unlikely(list_empty(target_list)))
+ return;
Is the unlikely a good idea here? Not having any targets may be
unusual but it isn't ridiculous. It
Hi,
On Tue, 10 Jul 2007, Duane Griffin wrote:
On 10/07/07, Satyam Sharma [EMAIL PROTECTED] wrote:
+ /* Avoid taking lock and disabling interrupts unnecessarily */
+ if (unlikely(list_empty(target_list)))
+ return;
Is the unlikely a good idea here? Not having
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote:
Hmm, I put it in there because I expected that the user must have had
at least one target configured (added to target_list) if he's got the
module loaded/built-in (and netconsole registered), which is when this
function would be
