Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

> The requirement is to be __aligned(2). I've added 4 instances of > ether_addr_copy with 8 addresses as arguments.  Of these, the 4 > src arguments are really the same type (i.e. nla_data acting on a > const nlattr*), so I'll try to reason about the 5 total cases below - > 1. cfg->dst_mac should

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

> This looks right to me, but doesn't ether_addr_copy() have alignment > requirements? Could someone more familiar with that review these > changes to ensure they're met? Thanks for catching this. The requirement is to be __aligned(2). I've added 4 instances of ether_addr_copy with 8 addresses as

Re: [PATCH v2 03/10] nl80211: Prefer ether_addr_copy

Hi All, On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani wrote: > This patch fixes the checkpatch,pl to prefer ether_addr_copy > over memcpy. > > Signed-off-by: Kirtika Ruchandani This looks right to me, but doesn't

[PATCH v2 03/10] nl80211: Prefer ether_addr_copy

This patch fixes the checkpatch,pl to prefer ether_addr_copy over memcpy. Signed-off-by: Kirtika Ruchandani --- net/wireless/nl80211.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index