Re: [PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

[Mugunthan V N]

On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote:
> Use of_platform_depopulate() in cpsw_remove() instead of
> of_device_unregister(), because CSPW child devices will not be
> recreated otherwise on next insmod. of_platform_depopulate() is
> correct way now as it will ensure that all steps done in
> of_platform_populate() are reverted, including cleaning up of
> OF_POPULATED flag.
> 
> Signed-off-by: Grygorii Strashko 

Reviewed-by: Mugunthan V N 

Regards
Mugunthan V N

[PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

[Grygorii Strashko]

Use of_platform_depopulate() in cpsw_remove() instead of
of_device_unregister(), because CSPW child devices will not be
recreated otherwise on next insmod. of_platform_depopulate() is
correct way now as it will ensure that all steps done in
of_platform_populate() are reverted, including cleaning up of
OF_POPULATED flag.

Signed-off-by: Grygorii Strashko 
---
 drivers/net/ethernet/ti/cpsw.c | 11 +--
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index ec6f473..f0ed470 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2566,15 +2566,6 @@ clean_ndev_ret:
return ret;
 }
 
-static int cpsw_remove_child_device(struct device *dev, void *c)
-{
-   struct platform_device *pdev = to_platform_device(dev);
-
-   of_device_unregister(pdev);
-
-   return 0;
-}
-
 static int cpsw_remove(struct platform_device *pdev)
 {
struct net_device *ndev = platform_get_drvdata(pdev);
@@ -2593,7 +2584,7 @@ static int cpsw_remove(struct platform_device *pdev)
 
cpsw_ale_destroy(priv->ale);
cpdma_ctlr_destroy(priv->dma);
-   device_for_each_child(>dev, NULL, cpsw_remove_child_device);
+   of_platform_depopulate(>dev);
pm_runtime_put_sync(>dev);
pm_runtime_disable(>dev);
if (priv->data.dual_emac)
-- 
2.9.2