Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

On Fri, Apr 07, 2017 at 10:15:02AM +0200, Juergen Borleis wrote: > When the LAN9303 device is in MDIO manged mode, all register accesses must > be done via MDIO. > > Please note: this code is *untested* yet due to the absence of such > configured hardware. It is based on a patch of Stefan Roese

Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

> +static const struct of_device_id lan9303_mdio_of_match[] = { > + { .compatible = "smsc,lan9303" }, > + { /* sentinel */ }, > +}; I just chatted with Dave about this. Please include mdio and i2c in the compatible string, so they are different. That will avoid any possible problems.

Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

From: Andrew Lunn Date: Fri, 7 Apr 2017 16:19:25 +0200 >> +static const struct of_device_id lan9303_mdio_of_match[] = { >> +{ .compatible = "smsc,lan9303" }, >> +{ /* sentinel */ }, >> +}; > > We still have the open question of is it a problem to have two > different

Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

> +static const struct of_device_id lan9303_mdio_of_match[] = { > + { .compatible = "smsc,lan9303" }, > + { /* sentinel */ }, > +}; We still have the open question of is it a problem to have two different drivers using the same compatible string. Changing these strings is hard, once they

[PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

When the LAN9303 device is in MDIO manged mode, all register accesses must be done via MDIO. Please note: this code is *untested* yet due to the absence of such configured hardware. It is based on a patch of Stefan Roese from 2014. Signed-off-by: Juergen Borleis ---