Re: [PATCH v2 net] net: sched: fix uses after free

2018-03-17 Thread David Miller
From: Eric Dumazet Date: Wed, 14 Mar 2018 18:53:00 -0700 > syzbot reported one use-after-free in pfifo_fast_enqueue() [1] > > Issue here is that we can not reuse skb after a successful skb_array_produce() > since another cpu might have consumed it already. > > I believe a

Re: [PATCH v2 net] net: sched: fix uses after free

2018-03-14 Thread John Fastabend
On 03/14/2018 08:10 PM, John Fastabend wrote: > On 03/14/2018 06:53 PM, Eric Dumazet wrote: >> syzbot reported one use-after-free in pfifo_fast_enqueue() [1] >> >> Issue here is that we can not reuse skb after a successful >> skb_array_produce() >> since another cpu might have consumed it

Re: [PATCH v2 net] net: sched: fix uses after free

2018-03-14 Thread John Fastabend
On 03/14/2018 06:53 PM, Eric Dumazet wrote: > syzbot reported one use-after-free in pfifo_fast_enqueue() [1] > > Issue here is that we can not reuse skb after a successful skb_array_produce() > since another cpu might have consumed it already. > > I believe a similar problem exists in

[PATCH v2 net] net: sched: fix uses after free

2018-03-14 Thread Eric Dumazet
syzbot reported one use-after-free in pfifo_fast_enqueue() [1] Issue here is that we can not reuse skb after a successful skb_array_produce() since another cpu might have consumed it already. I believe a similar problem exists in try_bulk_dequeue_skb_slow() in case we put an skb into