Re: [PATCH v2 net-next 0/2] platform data controls for mdio-gpio

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > Soon to be mainlined is an x86 platform with a Marvell switch, and a > bit-banging MDIO bus. In order to make this work, the phy_mask of the > MDIO bus needs to be set to prevent scanning for PHYs, and the > phy_ignore_ta_mask needs to be set because

Re: [PATCH v2 net-next 2/2] net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > The Marvell 6390 Ethernet switch family does not perform MDIO > turnaround correctly. Many hardware MDIO bus masters don't care about > this, but the bitbangging implementation in Linux does by default. Add > phy_ignore_ta_mask to the platform data so

Re: [PATCH v2 net-next 1/2] net: phy: mdio-gpio: Add platform_data support for phy_mask

2018-12-08 Thread Florian Fainelli
Le 12/8/18 à 7:12 AM, Andrew Lunn a écrit : > It is sometimes necessary to instantiate a bit-banging MDIO bus as a > platform device, without the aid of device tree. > > When device tree is being used, the bus is not scanned for devices, > only those devices which are in device tree are probed.

[PATCH v2 net-next 0/2] platform data controls for mdio-gpio

2018-12-08 Thread Andrew Lunn
Soon to be mainlined is an x86 platform with a Marvell switch, and a bit-banging MDIO bus. In order to make this work, the phy_mask of the MDIO bus needs to be set to prevent scanning for PHYs, and the phy_ignore_ta_mask needs to be set because the switch has broken turnaround. Add a

[PATCH v2 net-next 2/2] net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data

2018-12-08 Thread Andrew Lunn
The Marvell 6390 Ethernet switch family does not perform MDIO turnaround correctly. Many hardware MDIO bus masters don't care about this, but the bitbangging implementation in Linux does by default. Add phy_ignore_ta_mask to the platform data so that the bitbangging code can be told which devices

[PATCH v2 net-next 1/2] net: phy: mdio-gpio: Add platform_data support for phy_mask

2018-12-08 Thread Andrew Lunn
It is sometimes necessary to instantiate a bit-banging MDIO bus as a platform device, without the aid of device tree. When device tree is being used, the bus is not scanned for devices, only those devices which are in device tree are probed. Without device tree, by default, all addresses on the

Re: [Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-07 Thread David Miller
From: yupeng Date: Wed, 5 Dec 2018 18:56:28 -0800 > after set SO_DONTROUTE to 1, the IP layer should not route packets if > the dest IP address is not in link scope. But if the socket has cached > the dst_entry, such packets would be routed until the sk_dst_cache > expires. So we should clean

Re: [PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Miller
From: David Ahern Date: Fri, 7 Dec 2018 12:24:57 -0800 > From: David Ahern > > The existing garbage collection algorithm has a number of problems: ... > This patch addresses these problems as follows: > > 1. Use of a separate list_head to track entries that can be garbage >collected

Re: [PATCH v2 net-next 0/4] net: aquantia: add RSS configuration

2018-12-07 Thread David Miller
From: Igor Russkikh Date: Fri, 7 Dec 2018 14:00:09 + > In this patchset few bugs related to RSS are fixed and RSS table and > hash key configuration is added. > > We also do increase max number of HW rings upto 8. > > v2: removed extra arg check Series applied.

[PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-07 Thread David Ahern
From: David Ahern The existing garbage collection algorithm has a number of problems: 1. The gc algorithm will not evict PERMANENT entries as those entries are managed by userspace, yet the existing algorithm walks the entire hash table which means it always considers PERMANENT entries

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Ilias Apalodimas > Sent: Friday, December 7, 2018 7:52 PM > To: Ioana Ciocoi Radulescu > Cc: Jesper Dangaard Brouer ; > netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; dsah...@gmail.com; Camelia Alexandra Groza > >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > > I only did a quick grep around the driver so i might be missing something, > > but i can only see allocations via napi_alloc_frag(). XDP requires pages > > (either a single page per packet or a driver that does the page management > > of > > its own and fits 2 frames in a

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: Ilias Apalodimas > Sent: Friday, December 7, 2018 7:20 PM > To: Ioana Ciocoi Radulescu > Cc: Jesper Dangaard Brouer ; > netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; dsah...@gmail.com; Camelia Alexandra Groza >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ilias Apalodimas
Hi Ioana, > > > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > > actions are supported for now. Frame header changes are also > > > allowed. I only did a quick grep around the driver so i might be missing something, but i can only see allocations via napi_alloc_frag().

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-07 Thread Ioana Ciocoi Radulescu
za ; Ilias Apalodimas > > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support > > On Mon, 26 Nov 2018 16:27:28 + > Ioana Ciocoi Radulescu wrote: > > > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > > actions are supported for now. Fra

[PATCH v2 net-next 3/4] net: aquantia: fix initialization of RSS table

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Now RSS indirection table is initialized before setting up the number of hw queues, consequently the table may be filled by non existing queues. This patch moves the initialization when the number of hw queues is known. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor

[PATCH v2 net-next 1/4] net: aquantia: fix RSS table and key sizes

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Set RSS indirection table and RSS hash key sizes to their real size. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 4 ++-- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- 2 files changed, 3

[PATCH v2 net-next 4/4] net: aquantia: add support of RSS configuration

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Add support of configuration of RSS hash key and RSS indirection table. Signed-off-by: Dmitry Bogdanov Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/aq_ethtool.c | 36 +++ 1 file changed, 36 insertions(+) diff --git

[PATCH v2 net-next 2/4] net: aquantia: increase max number of hw queues

2018-12-07 Thread Igor Russkikh
From: Dmitry Bogdanov Increase the upper limit of the hw queues up to 8. This makes RSS better on multiheaded cpus. This is a maximum AQC hardware supports in one traffic class. The actual value is still limited by a number of available cpu cores. Signed-off-by: Dmitry Bogdanov

[PATCH v2 net-next 0/4] net: aquantia: add RSS configuration

2018-12-07 Thread Igor Russkikh
In this patchset few bugs related to RSS are fixed and RSS table and hash key configuration is added. We also do increase max number of HW rings upto 8. v2: removed extra arg check Dmitry Bogdanov (4): net: aquantia: fix RSS table and key sizes net: aquantia: increase max number of hw

Re: [PATCH v2 net-next 1/1] net: netem: use a list in addition to rbtree

2018-12-05 Thread David Miller
From: Peter Oskolkov Date: Tue, 4 Dec 2018 11:55:56 -0800 > When testing high-bandwidth TCP streams with large windows, > high latency, and low jitter, netem consumes a lot of CPU cycles > doing rbtree rebalancing. > > This patch uses a linear list/queue in addition to the rbtree: > if an

[Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-05 Thread yupeng
after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we should clean the sk_dst_cache when a user set SO_DONTROUTE option. Below

[Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-05 Thread yupeng
after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we should clean the sk_dst_cache when a user set SO_DONTROUTE option. Below

[Patch v2 net-next] call sk_dst_reset when set SO_DONTROUTE

2018-12-05 Thread yupeng
after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we should clean the sk_dst_cache when a user set SO_DONTROUTE option. Below

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-12-05 Thread Jesper Dangaard Brouer
On Mon, 26 Nov 2018 16:27:28 + Ioana Ciocoi Radulescu wrote: > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > actions are supported for now. Frame header changes are also > allowed. Do you have any XDP performance benchmarks on this hardware? Also what boards (and

Re: [PATCH v2 net-next] ip6_tunnel: Adding support of mapping rules for MAP-E tunnel

2018-12-04 Thread David Miller
From: Felix Jia Date: Mon, 3 Dec 2018 16:39:31 +1300 > +int > +ip6_get_addrport(struct iphdr *iph, __be32 *saddr4, __be32 *daddr4, > + __be16 *sport4, __be16 *dport4, __u8 *proto, int *icmperr) > +{ This looks like something the flow dissector can do alreayd, please look into

Re: [PATCH v2 net-next 1/1] net: netem: use a list in addition to rbtree

2018-12-04 Thread Eric Dumazet
On 12/04/2018 11:55 AM, Peter Oskolkov wrote: > When testing high-bandwidth TCP streams with large windows, > high latency, and low jitter, netem consumes a lot of CPU cycles > doing rbtree rebalancing. > > This patch uses a linear list/queue in addition to the rbtree: > if an incoming packet

[PATCH v2 net-next 0/1] net: netem: use a list _and_ rbtree

2018-12-04 Thread Peter Oskolkov
v2: address style suggestions by Stephen Hemminger. All changes are noop vs v1. Peter Oskolkov (1): net: netem: use a list in addition to rbtree net/sched/sch_netem.c | 89 +-- 1 file changed, 69 insertions(+), 20 deletions(-)

[PATCH v2 net-next 1/1] net: netem: use a list in addition to rbtree

2018-12-04 Thread Peter Oskolkov
When testing high-bandwidth TCP streams with large windows, high latency, and low jitter, netem consumes a lot of CPU cycles doing rbtree rebalancing. This patch uses a linear list/queue in addition to the rbtree: if an incoming packet is past the tail of the linear queue, it is added there,

[PATCH v2 net-next] ip6_tunnel: Adding support of mapping rules for MAP-E tunnel

2018-12-02 Thread Felix Jia
From: Blair Steven Mapping of Addresses and Ports with Encapsulation (MAP-E) is defined in RFC7597, and is an IPv6 transition technology providing interoperability between IPv4 and IPv6 networks. MAP-E uses the encapsulation mode described in RFC2473 (IPv6 Tunneling) to transport IPv4 and IPv6

Re: [PATCH v2 net-next] cxgb4: number of VFs supported is not always 16

2018-11-30 Thread David Miller
From: Ganesh Goudar Date: Tue, 27 Nov 2018 14:59:06 +0530 > Total number of VFs supported by PF is used to determine the last > byte of VF's mac address. Number of VFs supported is not always > 16, use the variable nvfs to get the number of VFs supported > rather than hard coding it to 16. > >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Wed, 28 Nov 2018 09:18:28 + > They apply cleanly for me. I figured out what happend. The patches were mis-ordered (specifically patches #3 and #4) when I added them to the patchwork bundle, and that is what causes them to fail. Series applied, thanks!

Re: [PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP support

2018-11-28 Thread David Ahern
On 11/26/18 9:27 AM, Ioana Ciocoi Radulescu wrote: > We keep one XDP program reference per channel. The only actions > supported for now are XDP_DROP and XDP_PASS. > > Until now we didn't enforce a maximum size for Rx frames based > on MTU value. Change that, since for XDP mode we must ensure no

Re: [PATCH v2 net-next 8/8] dpaa2-eth: Add xdp counters

2018-11-28 Thread David Ahern
On 11/26/18 9:27 AM, Ioana Ciocoi Radulescu wrote: > Add counters for xdp processed frames to the channel statistics. > > Signed-off-by: Ioana Radulescu > --- > v2: no changes > Reviewed-by: David Ahern

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread David Ahern
xandra Groza >> Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support >> >> From: Ioana Ciocoi Radulescu >> Date: Mon, 26 Nov 2018 16:27:28 + >> >>> Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX >>> actions a

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-28 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: David Miller > Sent: Wednesday, November 28, 2018 2:25 AM > To: Ioana Ciocoi Radulescu > Cc: netdev@vger.kernel.org; Ioana Ciornei ; > dsah...@gmail.com; Camelia Alexandra Groza > Subject: Re: [PATCH v2 net-next 0/8] dpaa2-eth:

Re: [PATCH v2 net-next] tcp: remove hdrlen argument from tcp_queue_rcv()

2018-11-27 Thread David Miller
From: Eric Dumazet Date: Mon, 26 Nov 2018 14:49:12 -0800 > Only one caller needs to pull TCP headers, so lets > move __skb_pull() to the caller side. > > Signed-off-by: Eric Dumazet > Acked-by: Yuchung Cheng > --- > v2: sent as a standalone patch. Applied, thanks Eric.

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-27 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Mon, 26 Nov 2018 16:27:28 + > Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX > actions are supported for now. Frame header changes are also > allowed. > > v2: - count the XDP packets in the rx/tx inteface stats > - add message with

Re: [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue

2018-11-27 Thread Eric Dumazet
On Tue, Nov 27, 2018 at 2:13 PM Eric Dumazet wrote: > > > > On 11/27/2018 01:58 PM, Neal Cardwell wrote: > > > I wonder if technically perhaps the logic should skip coalescing if > > the tail or skb has the TCP_FLAG_URG bit set? It seems if skbs are > > coalesced, and some have urgent data and

Re: [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue

2018-11-27 Thread Eric Dumazet
On 11/27/2018 01:58 PM, Neal Cardwell wrote: > I wonder if technically perhaps the logic should skip coalescing if > the tail or skb has the TCP_FLAG_URG bit set? It seems if skbs are > coalesced, and some have urgent data and some do not, then the > TCP_FLAG_URG bit will be accumulated into

Re: [PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue

2018-11-27 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote: > > In case GRO is not as efficient as it should be or disabled, > we might have a user thread trapped in __release_sock() while > softirq handler flood packets up to the point we have to drop. > > This patch balances work done from user thread

Re: [PATCH v2 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack()

2018-11-27 Thread Eric Dumazet
On 11/27/2018 01:19 PM, Neal Cardwell wrote: > On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote: >> >> Neal pointed out that non sack flows might suffer from ACK compression >> added in the following patch ("tcp: implement coalescing on backlog queue") >> >> Instead of tweaking

Re: [PATCH v2 net-next 3/4] tcp: make tcp_space() aware of socket backlog

2018-11-27 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote: > > Jean-Louis Dupond reported poor iscsi TCP receive performance > that we tracked to backlog drops. > > Apparently we fail to send window updates reflecting the > fact that we are under stress. > > Note that we might lack a proper window

Re: [PATCH v2 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack()

2018-11-27 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote: > > Neal pointed out that non sack flows might suffer from ACK compression > added in the following patch ("tcp: implement coalescing on backlog queue") > > Instead of tweaking tcp_add_backlog() we can take into > account how many ACK were

Re: [PATCH v2 net-next 1/4] tcp: hint compiler about sack flows

2018-11-27 Thread Neal Cardwell
On Tue, Nov 27, 2018 at 10:57 AM Eric Dumazet wrote: > > Tell the compiler that most TCP flows are using SACK these days. > > There is no need to add the unlikely() clause in tcp_is_reno(), > the compiler is able to infer it. > > Signed-off-by: Eric Dumazet > --- Acked-by: Neal Cardwell Nice.

Re: [PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress

2018-11-27 Thread Yuchung Cheng
On Tue, Nov 27, 2018 at 7:57 AM, Eric Dumazet wrote: > While working on the SACK compression issue Jean-Louis Dupond > reported, we found that his linux box was suffering very hard > from tail drops on the socket backlog queue. > > First patch hints the compiler about sack flows being the norm. >

[PATCH v2 net-next 2/4] tcp: take care of compressed acks in tcp_add_reno_sack()

2018-11-27 Thread Eric Dumazet
Neal pointed out that non sack flows might suffer from ACK compression added in the following patch ("tcp: implement coalescing on backlog queue") Instead of tweaking tcp_add_backlog() we can take into account how many ACK were coalesced, this information will be available in

[PATCH v2 net-next 4/4] tcp: implement coalescing on backlog queue

2018-11-27 Thread Eric Dumazet
In case GRO is not as efficient as it should be or disabled, we might have a user thread trapped in __release_sock() while softirq handler flood packets up to the point we have to drop. This patch balances work done from user thread and softirq, to give more chances to __release_sock() to

[PATCH v2 net-next 3/4] tcp: make tcp_space() aware of socket backlog

2018-11-27 Thread Eric Dumazet
Jean-Louis Dupond reported poor iscsi TCP receive performance that we tracked to backlog drops. Apparently we fail to send window updates reflecting the fact that we are under stress. Note that we might lack a proper window increase when backlog is fully processed, since __release_sock() clears

[PATCH v2 net-next 1/4] tcp: hint compiler about sack flows

2018-11-27 Thread Eric Dumazet
Tell the compiler that most TCP flows are using SACK these days. There is no need to add the unlikely() clause in tcp_is_reno(), the compiler is able to infer it. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 net-next 0/4] tcp: take a bit more care of backlog stress

2018-11-27 Thread Eric Dumazet
While working on the SACK compression issue Jean-Louis Dupond reported, we found that his linux box was suffering very hard from tail drops on the socket backlog queue. First patch hints the compiler about sack flows being the norm. Second patch changes non-sack code in preparation of the ack

RE: [PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP support

2018-11-27 Thread Camelia Alexandra Groza
> -Original Message- > From: Ioana Ciocoi Radulescu > Sent: Monday, November 26, 2018 18:27 > To: netdev@vger.kernel.org; da...@davemloft.net > Cc: Ioana Ciornei ; dsah...@gmail.com; Camelia > Alexandra Groza > Subject: [PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP

[PATCH v2 net-next] cxgb4: number of VFs supported is not always 16

2018-11-27 Thread Ganesh Goudar
Total number of VFs supported by PF is used to determine the last byte of VF's mac address. Number of VFs supported is not always 16, use the variable nvfs to get the number of VFs supported rather than hard coding it to 16. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- V2: Fixes

[PATCH v2 net-next] tcp: remove hdrlen argument from tcp_queue_rcv()

2018-11-26 Thread Eric Dumazet
Only one caller needs to pull TCP headers, so lets move __skb_pull() to the caller side. Signed-off-by: Eric Dumazet Acked-by: Yuchung Cheng --- v2: sent as a standalone patch. net/ipv4/tcp_input.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH v2 net-next 6/8] dpaa2-eth: Add support for XDP_TX

2018-11-26 Thread Ioana Ciocoi Radulescu
Send frames back on the same port for XDP_TX action. Since the frame buffers have been allocated by us, we can recycle them directly into the Rx buffer pool instead of requesting a confirmation frame upon transmission complete. Signed-off-by: Ioana Radulescu --- v2: XDP_TX packets count towards

[PATCH v2 net-next 2/8] dpaa2-eth: Allow XDP header adjustments

2018-11-26 Thread Ioana Ciocoi Radulescu
Reserve XDP_PACKET_HEADROOM bytes in Rx buffers to allow XDP programs to increase frame header size. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43 ++-- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git

[PATCH v2 net-next 7/8] dpaa2-eth: Cleanup channel stats

2018-11-26 Thread Ioana Ciocoi Radulescu
Remove unused counter. Reorder fields in channel stats structure to match the ethtool strings order and make it easier to print them with ethtool -S. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 -

[PATCH v2 net-next 3/8] dpaa2-eth: Move function

2018-11-26 Thread Ioana Ciocoi Radulescu
We'll use function free_bufs() on the XDP path as well, so move it higher in order to avoid a forward declaration. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 34 1 file changed, 17 insertions(+), 17 deletions(-)

[PATCH v2 net-next 5/8] dpaa2-eth: Map Rx buffers as bidirectional

2018-11-26 Thread Ioana Ciocoi Radulescu
In order to support enqueueing Rx FDs back to hardware, we need to DMA map Rx buffers as bidirectional. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 net-next 8/8] dpaa2-eth: Add xdp counters

2018-11-26 Thread Ioana Ciocoi Radulescu
Add counters for xdp processed frames to the channel statistics. Signed-off-by: Ioana Radulescu --- v2: no changes drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +++ drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 4 drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c |

[PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

2018-11-26 Thread Ioana Ciocoi Radulescu
Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX actions are supported for now. Frame header changes are also allowed. v2: - count the XDP packets in the rx/tx inteface stats - add message with the maximum supported MTU value for XDP Ioana Radulescu (8): dpaa2-eth: Add

[PATCH v2 net-next 4/8] dpaa2-eth: Release buffers back to pool on XDP_DROP

2018-11-26 Thread Ioana Ciocoi Radulescu
Instead of freeing the RX buffers, release them back into the pool. We wait for the maximum number of buffers supported by a single release command to accumulate before issuing the command. Also, don't unmap the Rx buffers at the beginning of the Rx routine anymore, since that would require

[PATCH v2 net-next 1/8] dpaa2-eth: Add basic XDP support

2018-11-26 Thread Ioana Ciocoi Radulescu
We keep one XDP program reference per channel. The only actions supported for now are XDP_DROP and XDP_PASS. Until now we didn't enforce a maximum size for Rx frames based on MTU value. Change that, since for XDP mode we must ensure no scatter-gather frames can be received. Signed-off-by: Ioana

[PATCH v2 net-next] net: remove unsafe skb_insert()

2018-11-25 Thread Eric Dumazet
I do not see how one can effectively use skb_insert() without holding some kind of lock. Otherwise other cpus could have changed the list right before we have a chance of acquiring list->lock. Only existing user is in drivers/infiniband/hw/nes/nes_mgt.c and this one probably meant to use

Re: [PATCH v2 net-next] net: lpc_eth: fix trivial comment typo

2018-11-21 Thread David Miller
From: Andrea Claudi Date: Tue, 20 Nov 2018 18:30:30 +0100 > Fix comment typo rxfliterctrl -> rxfilterctrl > > Signed-off-by: Andrea Claudi Applied.

Re: [PATCH v2 net-next] cxgb4/cxgb4vf: Fix mac_hlist initialization and free

2018-11-20 Thread David Miller
From: Arjun Vynipadath Date: Tue, 20 Nov 2018 12:11:39 +0530 > Null pointer dereference seen when cxgb4vf driver is unloaded > without bringing up any interfaces, moving mac_hlist initialization > to driver probe and free the mac_hlist in remove to fix the issue. > > Fixes: 24357e06ba51

[PATCH v2 net-next] net: lpc_eth: fix trivial comment typo

2018-11-20 Thread Andrea Claudi
Fix comment typo rxfliterctrl -> rxfilterctrl Signed-off-by: Andrea Claudi --- drivers/net/ethernet/nxp/lpc_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index bd8695a4faaa..89d17399fb5a

[PATCH v2 net-next] cxgb4/cxgb4vf: Fix mac_hlist initialization and free

2018-11-19 Thread Arjun Vynipadath
Null pointer dereference seen when cxgb4vf driver is unloaded without bringing up any interfaces, moving mac_hlist initialization to driver probe and free the mac_hlist in remove to fix the issue. Fixes: 24357e06ba51 ("cxgb4vf: fix memleak in mac_hlist initialization") Signed-off-by: Arjun

[PATCH V2 net-next 0/5] net: hns3: Add support of hardware GRO to HNS3 Driver

2018-11-15 Thread Salil Mehta
This patch-set adds support of hardware assisted GRO feature to HNS3 driver on Rev B(=0x21) platform. Current hardware only supports TCP/IPv{4|6} flows. Change Log: V1->V2: 1. Remove redundant print reported by Leon Romanovsky. Link: https://lkml.org/lkml/2018/11/13/715 Peng Li (5): net:

Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

2018-11-09 Thread David Miller
From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:35:52 +0100 > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with

Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

2018-11-09 Thread Florian Fainelli
On 11/9/18 9:35 AM, Heiner Kallweit wrote: > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with this member in a

Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

2018-11-09 Thread Andrew Lunn
On Fri, Nov 09, 2018 at 06:35:52PM +0100, Heiner Kallweit wrote: > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing

[PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

2018-11-09 Thread Heiner Kallweit
As a heritage from the very early days of phylib member interrupts is defined as u32 even though it's just a flag whether interrupts are enabled. So we can change it to a bitfield member. In addition change the code dealing with this member in a way that it's clear we're dealing with a bool value.

Re: [PATCH v2 net-next] sock: Reset dst when changing sk_mark via setsockopt

2018-11-07 Thread Eric Dumazet
On 11/07/2018 08:55 PM, David Barmann wrote: > When setting the SO_MARK socket option, the dst needs to be reset so > that a new route lookup is performed. > > This fixes the case where an application wants to change routing by > setting a new sk_mark. If this is done after some packets have

[PATCH v2 net-next] sock: Reset dst when changing sk_mark via setsockopt

2018-11-07 Thread David Barmann
When setting the SO_MARK socket option, the dst needs to be reset so that a new route lookup is performed. This fixes the case where an application wants to change routing by setting a new sk_mark. If this is done after some packets have already been sent, the dst is cached and has no effect.

Re: [PATCH v2 net-next 0/8] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

2018-10-19 Thread Florian Fainelli
i Sharshevsky ; UNGLinuxDriver >> ; netdev@vger.kernel.org >> Subject: Re: [PATCH v2 net-next 0/8] net: dsa: microchip: Modify KSZ9477 >> DSA driver in preparation to add other KSZ switch drivers >> >> On 12/05/2017 05:46 PM, tristram...@microchip.com wrote: >>

Re: [PATCH V2 net-next] net: ena: Fix Kconfig dependency on X86

2018-10-17 Thread David Miller
From: Date: Wed, 17 Oct 2018 10:04:21 + > From: Netanel Belgazal > > The Kconfig limitation of X86 is to too wide. > The ENA driver only requires a little endian dependency. > > Change the dependency to be on little endian CPU. > > Signed-off-by: Netanel Belgazal Applied.

[PATCH V2 net-next] net: ena: Fix Kconfig dependency on X86

2018-10-17 Thread netanel
From: Netanel Belgazal The Kconfig limitation of X86 is to too wide. The ENA driver only requires a little endian dependency. Change the dependency to be on little endian CPU. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 net-next 00/11] net: Kernel side filtering for route dumps

2018-10-16 Thread David Miller
From: David Ahern Date: Mon, 15 Oct 2018 18:56:40 -0700 > From: David Ahern > > Implement kernel side filtering of route dumps by protocol (e.g., which > routing daemon installed the route), route type (e.g., unicast), table > id and nexthop device. > > iproute2 has been doing this filtering

[PATCH v2 net-next 06/11] ipmr: Refactor mr_rtm_dumproute

2018-10-15 Thread David Ahern
From: David Ahern Move per-table loops from mr_rtm_dumproute to mr_table_dump and export mr_table_dump for dumps by specific table id. Signed-off-by: David Ahern --- include/linux/mroute_base.h | 6 net/ipv4/ipmr_base.c| 88 - 2 files

[PATCH v2 net-next 01/11] netlink: Add answer_flags to netlink_callback

2018-10-15 Thread David Ahern
From: David Ahern With dump filtering we need a way to ensure the NLM_F_DUMP_FILTERED flag is set on a message back to the user if the data returned is influenced by some input attributes. Normally this can be done as messages are added to the skb, but if the filter results in no data being

[PATCH v2 net-next 05/11] net/mpls: Plumb support for filtering route dumps

2018-10-15 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by egress device index and protocol. MPLS uses only a single table and route type. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-)

[PATCH v2 net-next 11/11] net/ipv4: Bail early if user only wants prefix entries

2018-10-15 Thread David Ahern
From: David Ahern Unlike IPv6, IPv4 does not have routes marked with RTF_PREFIX_RT. If the flag is set in the dump request, just return. In the process of this change, move the CLONE check to use the new filter flags. Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 8 ++-- 1

[PATCH v2 net-next 07/11] net: Plumb support for filtering ipv4 and ipv6 multicast route dumps

2018-10-15 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by egress device index and table id. If the table id is given in the filter, lookup table and call mr_table_dump directly for it. Signed-off-by: David Ahern --- include/linux/mroute_base.h | 7 --- net/ipv4/ipmr.c |

[PATCH v2 net-next 10/11] net/ipv6: Bail early if user only wants cloned entries

2018-10-15 Thread David Ahern
From: David Ahern Similar to IPv4, IPv6 fib no longer contains cloned routes. If a user requests a route dump for only cloned entries, no sense walking the FIB and returning everything. Signed-off-by: David Ahern --- net/ipv6/ip6_fib.c | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH v2 net-next 09/11] net/mpls: Handle kernel side filtering of route dumps

2018-10-15 Thread David Ahern
From: David Ahern Update the dump request parsing in MPLS for the non-INET case to enable kernel side filtering. If INET is disabled the only filters that make sense for MPLS are protocol and nexthop device. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 33

[PATCH v2 net-next 04/11] net/ipv6: Plumb support for filtering route dumps

2018-10-15 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by table id, egress device index, protocol, and route type. If the table id is given in the filter, lookup the table and call fib6_dump_table directly for it. Move the existing route flags check for prefix only routes to the new

[PATCH v2 net-next 02/11] net: Add struct for fib dump filter

2018-10-15 Thread David Ahern
From: David Ahern Add struct fib_dump_filter for options on limiting which routes are returned in a dump request. The current list is table id, protocol, route type, rtm_flags and nexthop device index. struct net is needed to lookup the net_device from the index. Declare the filter for each

[PATCH v2 net-next 08/11] net: Enable kernel side filtering of route dumps

2018-10-15 Thread David Ahern
From: David Ahern Update parsing of route dump request to enable kernel side filtering. Allow filtering results by protocol (e.g., which routing daemon installed the route), route type (e.g., unicast), table id and nexthop device. These amount to the low hanging fruit, yet a huge improvement,

[PATCH v2 net-next 00/11] net: Kernel side filtering for route dumps

2018-10-15 Thread David Ahern
From: David Ahern Implement kernel side filtering of route dumps by protocol (e.g., which routing daemon installed the route), route type (e.g., unicast), table id and nexthop device. iproute2 has been doing this filtering in userspace for years; pushing the filters to the kernel side reduces

[PATCH v2 net-next 03/11] net/ipv4: Plumb support for filtering route dumps

2018-10-15 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by table id, egress device index, protocol and route type. If the table id is given in the filter, lookup the table and call fib_table_dump directly for it. Signed-off-by: David Ahern --- include/net/ip_fib.h| 2 +-

Re: [PATCH V2 net-next 5/5] ptp: Add a driver for InES time stamping IP core.

2018-10-12 Thread Rob Herring
On Sun, Oct 07, 2018 at 10:38:23AM -0700, Richard Cochran wrote: > The InES at the ZHAW offers a PTP time stamping IP core. The FPGA > logic recognizes and time stamps PTP frames on the MII bus. This > patch adds a driver for the core along with a device tree binding to > allow hooking the

Re: [PATCH v2 net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-12 Thread David Miller
From: David Ahern Date: Thu, 11 Oct 2018 20:17:21 -0700 > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or

[PATCH v2 net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-11 Thread David Ahern
From: David Ahern Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE notifications when a device is taken down (admin down) or deleted. IPv4 does not generate a message for routes evicted by the down or delete; IPv6 does. A NOS at scale really needs to avoid these

Re: [PATCH V2 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-11 Thread David Miller
From: Date: Thu, 11 Oct 2018 11:26:15 +0300 > From: Arthur Kiyanovski > > This patchset introduces the following: > 1. A new placement policy of Tx headers and descriptors, which takes > advantage of an option to place headers + descriptors in device memory > space. This is sometimes referred

[PATCH V2 net-next 11/12] net: ena: update driver version to 2.0.1

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h index

[PATCH V2 net-next 10/12] net: ena: remove redundant parameter in ena_com_admin_init()

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Remove redundant spinlock acquire parameter from ena_com_admin_init() Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 6 ++ drivers/net/ethernet/amazon/ena/ena_com.h| 5 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 2

[PATCH V2 net-next 09/12] net: ena: change rx copybreak default to reduce kernel memory pressure

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Improves socket memory utilization when receiving packets larger than 128 bytes (the previous rx copybreak) and smaller than 256 bytes. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V2 net-next 07/12] net: ena: explicit casting and initialization, and clearer error handling

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 39 drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 22 3 files changed, 36

[PATCH V2 net-next 12/12] net: ena: fix indentations in ena_defs for better readability

2018-10-11 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 334 +- drivers/net/ethernet/amazon/ena/ena_eth_io_defs.h | 223 +++ drivers/net/ethernet/amazon/ena/ena_regs_defs.h | 206 +++-- 3 files

  1   2   3   4   5   6   7   8   9   10   >