Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-05 Thread David Miller
From: YueHaibing Date: Tue, 4 Sep 2018 02:56:26 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/net_failover.c: In function 'net_failover_slave_unregister': > drivers/net/net_failover.c:598:35: warning: > variable 'primary_dev' set but not used

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-04 Thread Samudrala, Sridhar
On 9/3/2018 7:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check

Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-04 Thread Liran Alon
- yuehaib...@huawei.com wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/net_failover.c: In function > 'net_failover_slave_unregister': > drivers/net/net_failover.c:598:35: warning: > variable 'primary_dev' set but not used [-Wunused-but-set-variable] > > There

[PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-03 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] There should check the validity of 'slave_dev'. Fixes: