Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-25 Thread Nishanth Devarajan
On Sun, Jun 24, 2018 at 11:43:07AM -0400, Jamal Hadi Salim wrote: > On 23/06/18 04:47 PM, Nishanth Devarajan wrote: > [..] > > >+/* Drop the packet at the tail of the lowest priority qdisc. */ > >+lp_qdisc = >qdiscs[lp]; > >+to_drop = __skb_dequeue_tail(lp_qdisc); > >+

Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-25 Thread Nishanth Devarajan
On Sat, Jun 23, 2018 at 03:10:32PM -0700, Alexander Duyck wrote: > On Sat, Jun 23, 2018 at 1:47 PM, Nishanth Devarajan > wrote: > > net/sched: add skbprio scheduler > > > > Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes > > packets > > according to their skb->priority

Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-25 Thread Nishanth Devarajan
On Sat, Jun 23, 2018 at 02:43:16PM -0700, Cong Wang wrote: > On Sat, Jun 23, 2018 at 1:47 PM, Nishanth Devarajan > wrote: > > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > > index 37b5096..6fd07e8 100644 > > --- a/include/uapi/linux/pkt_sched.h > > +++

Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-24 Thread Jamal Hadi Salim
On 23/06/18 04:47 PM, Nishanth Devarajan wrote: [..] + /* Drop the packet at the tail of the lowest priority qdisc. */ + lp_qdisc = >qdiscs[lp]; + to_drop = __skb_dequeue_tail(lp_qdisc); + BUG_ON(!to_drop); + qdisc_qstats_backlog_dec(sch, to_drop); +

Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-23 Thread Alexander Duyck
On Sat, Jun 23, 2018 at 1:47 PM, Nishanth Devarajan wrote: > net/sched: add skbprio scheduler > > Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets > according to their skb->priority field. Although Skbprio can be employed in > any > scenario in which a higher

Re: [PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-23 Thread Cong Wang
On Sat, Jun 23, 2018 at 1:47 PM, Nishanth Devarajan wrote: > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > index 37b5096..6fd07e8 100644 > --- a/include/uapi/linux/pkt_sched.h > +++ b/include/uapi/linux/pkt_sched.h ... > +#define SKBPRIO_MAX_PRIORITY 64 > + >

[PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-23 Thread Nishanth Devarajan
net/sched: add skbprio scheduler Skbprio (SKB Priority Queue) is a queueing discipline that prioritizes packets according to their skb->priority field. Although Skbprio can be employed in any scenario in which a higher skb->priority field means a higher priority packet, Skbprio was concieved as a

[PATCH v2 net-next] net/sched: add skbprio scheduler

2018-06-06 Thread Nishanth Devarajan
net/sched: add skbprio scheduler Skbprio (SKB Priority Queue) is a queuing discipline that prioritizes IPv4 and IPv6 packets according to their skb->priority field. Although Skbprio can be employed in any scenario in which a higher skb->priority field means a higher priority packet, Skbprio was