Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time

2016-10-23 Thread David Miller
From: f...@ikuai8.com Date: Fri, 21 Oct 2016 19:02:15 +0800 > From: Gao Feng > > Current tun driver permits the ifr_flags is set with IFF_TUN and > IFF_TAP at the same time. But actually there is only IFF_TUN flag > works. And it does not make sense these two flags are set, so

Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time

2016-10-21 Thread Gao Feng
Hi Eric, On Fri, Oct 21, 2016 at 7:28 PM, Eric Dumazet wrote: > On Fri, 2016-10-21 at 19:02 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> Current tun driver permits the ifr_flags is set with IFF_TUN and >> IFF_TAP at the same time. But actually

Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time

2016-10-21 Thread Eric Dumazet
On Fri, 2016-10-21 at 19:02 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > Current tun driver permits the ifr_flags is set with IFF_TUN and > IFF_TAP at the same time. But actually there is only IFF_TUN flag > works. And it does not make sense these two flags are set, so add

[PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time

2016-10-21 Thread fgao
From: Gao Feng Current tun driver permits the ifr_flags is set with IFF_TUN and IFF_TAP at the same time. But actually there is only IFF_TUN flag works. And it does not make sense these two flags are set, so add this check. Signed-off-by: Gao Feng --- v2: