Re: [PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-15 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code. On Fri, Sep 09, 2016 at 03:18:32PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > > +static int vsc85xx_edge_rate_cntl_set(struct phy_device *phydev, > > > > + u8 edge_rate) > > > > > > No spaces place. > > >

Re: [PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-09 Thread Andrew Lunn
> > > +static int vsc85xx_edge_rate_cntl_set(struct phy_device *phydev, > > > + u8 edge_rate) > > > > No spaces place. > > > I ran the checkpatch. I did not find any error. I created another workspace > and > applied the same patch. It shows the correct alig

Re: [PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
Hi Andrew, Thank you for review the code and valuable comments. On Thu, Sep 08, 2016 at 03:14:15PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Thu, Sep 08, 2016 at 02:47:21PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > Used Device Tree to configure the Edge-rate as pe

Re: [PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-08 Thread Andrew Lunn
On Thu, Sep 08, 2016 at 02:47:21PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > Used Device Tree to configure the Edge-rate as per review comments and > re-sending code for review > > Signed-off-by: Raju Lakkaraju > --- > drivers/net/phy/mscc.c | 76 > ++

[PATCH v2 net-next 1/2] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-08 Thread Raju Lakkaraju
From: Raju Lakkaraju Used Device Tree to configure the Edge-rate as per review comments and re-sending code for review Signed-off-by: Raju Lakkaraju --- drivers/net/phy/mscc.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/drivers/net/ph