Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Pavel Belous 



On 03/23/2017 12:44 AM, Florian Fainelli wrote:

On 03/22/2017 02:19 PM, Pavel Belous wrote:

From: Pavel Belous 

The following patchset containg several fixes for aQuantia AQtion driver
for net tree: A couple fixes for IPv6 and other fixes.

v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead
HW_ATL_B0_TXD_CTL_CMD_IPV6).


Since you are fixing bugs, can you add proper Fixes: <12-digit commit>
("Commit subject") tags for each commit?

Also, you may want to fix your subjects to be:

net: ethernet: aquantia: Remove adapter re-opening when MTU changed

Thanks!



Thank you, Florian.
I will add 'Fixes' tags in patchset v3.

Regards,
Pavel




Pavel Belous (5):
  net:ethernet:aquantia: Remove adapter re-opening when mtu changed.
  net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.
  net:ethernet:aquantia: Missing spinlock initialization.
  net:ethernet:aquantia: Fix for LSO with IPv6.
  net:ethernet:aquantia: Reset is_gso flag when EOP reached.

 drivers/net/ethernet/aquantia/atlantic/aq_main.c   |  5 -
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 23 ++
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |  1 +
 drivers/net/ethernet/aquantia/atlantic/aq_ring.h   |  3 ++-
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |  4 
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |  4 
 6 files changed, 30 insertions(+), 10 deletions(-)

Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Florian Fainelli 
On 03/22/2017 02:19 PM, Pavel Belous wrote:
> From: Pavel Belous 
> 
> The following patchset containg several fixes for aQuantia AQtion driver
> for net tree: A couple fixes for IPv6 and other fixes.
> 
> v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead
> HW_ATL_B0_TXD_CTL_CMD_IPV6).

Since you are fixing bugs, can you add proper Fixes: <12-digit commit>
("Commit subject") tags for each commit?

Also, you may want to fix your subjects to be:

net: ethernet: aquantia: Remove adapter re-opening when MTU changed

Thanks!

> 
> 
> Pavel Belous (5):
>   net:ethernet:aquantia: Remove adapter re-opening when mtu changed.
>   net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.
>   net:ethernet:aquantia: Missing spinlock initialization.
>   net:ethernet:aquantia: Fix for LSO with IPv6.
>   net:ethernet:aquantia: Reset is_gso flag when EOP reached.
> 
>  drivers/net/ethernet/aquantia/atlantic/aq_main.c   |  5 -
>  drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 23 
> ++
>  drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |  1 +
>  drivers/net/ethernet/aquantia/atlantic/aq_ring.h   |  3 ++-
>  .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |  4 
>  .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |  4 
>  6 files changed, 30 insertions(+), 10 deletions(-)
> 


-- 
Florian

[PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Pavel Belous 
From: Pavel Belous 

The following patchset containg several fixes for aQuantia AQtion driver
for net tree: A couple fixes for IPv6 and other fixes.

v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead
HW_ATL_B0_TXD_CTL_CMD_IPV6).


Pavel Belous (5):
  net:ethernet:aquantia: Remove adapter re-opening when mtu changed.
  net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.
  net:ethernet:aquantia: Missing spinlock initialization.
  net:ethernet:aquantia: Fix for LSO with IPv6.
  net:ethernet:aquantia: Reset is_gso flag when EOP reached.

 drivers/net/ethernet/aquantia/atlantic/aq_main.c   |  5 -
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 23 ++
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |  1 +
 drivers/net/ethernet/aquantia/atlantic/aq_ring.h   |  3 ++-
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |  4 
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |  4 
 6 files changed, 30 insertions(+), 10 deletions(-)

-- 
2.7.4