Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-22 Thread Kalle Valo
Johannes Berg writes: > On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote: >> On Sunday 17 April 2016 14:42:33 Johannes Berg wrote: >> > >> > I was thinking more restrictively of just the stuff that can't even >> > be built without modifying the sources - like

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-19 Thread Johannes Berg
On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote: > On Sunday 17 April 2016 14:42:33 Johannes Berg wrote: > > > > > > I was thinking more restrictively of just the stuff that can't even > > be > > built without modifying the sources - like the "#if VERBOSE" thing. > All the DEBUG()

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-17 Thread Arnd Bergmann
On Sunday 17 April 2016 14:42:33 Johannes Berg wrote: > > I was thinking more restrictively of just the stuff that can't even be > built without modifying the sources - like the "#if VERBOSE" thing. All the DEBUG() statements are inside of this kind of check, so if we remove the #ifdefs, it

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-17 Thread Johannes Berg
On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote: > On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote: > > > > > > > > The patch was build-tested / debugged by removing the > > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-16 Thread Arnd Bergmann
On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote: > > The patch was build-tested / debugged by removing the > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > code, since I don't think anyone really ever touches this

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-13 Thread Arend Van Spriel
On 13-4-2016 10:38, Johannes Berg wrote: > >> The patch was build-tested / debugged by removing the >> "if VERBOSE > SHOW_ERROR_MESSAGES" guards. > > Stands to reason that we should just remove the (more or less) dead > code, since I don't think anyone really ever touches this driver any > more

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-13 Thread Johannes Berg
> The patch was build-tested / debugged by removing the > "if VERBOSE > SHOW_ERROR_MESSAGES" guards. Stands to reason that we should just remove the (more or less) dead code, since I don't think anyone really ever touches this driver any more or will ever again ... johannes

[PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

2016-04-13 Thread Tina Ruchandani
'struct timeval' uses a 32-bit seconds field which will overflow in year 2038 and beyond. This patch is part of a larger effort to remove all instances of 'struct timeval' from the kernel and replace them with 64-bit timekeeping variables. The patch also fixes the debug printf specifier to avoid