Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-30 Thread Jiri Pirko
Sun, May 27, 2018 at 11:17:29PM CEST, vla...@mellanox.com wrote: >Act API used linked list to pass set of actions to functions. It is >intrusive data structure that stores list nodes inside action structure >itself, which means it is not safe to modify such list concurrently. >However, action API

Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-29 Thread Vlad Buslov
On Mon 28 May 2018 at 21:31, Marcelo Ricardo Leitner wrote: > On Mon, May 28, 2018 at 12:17:29AM +0300, Vlad Buslov wrote: > ... >> -int tcf_action_destroy(struct list_head *actions, int bind) >> +int tcf_action_destroy(struct tc_action *actions[], int bind) >> { >> const struct

Re: [PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-28 Thread Marcelo Ricardo Leitner
On Mon, May 28, 2018 at 12:17:29AM +0300, Vlad Buslov wrote: ... > -int tcf_action_destroy(struct list_head *actions, int bind) > +int tcf_action_destroy(struct tc_action *actions[], int bind) > { > const struct tc_action_ops *ops; > - struct tc_action *a, *tmp; > - int ret = 0; > +

[PATCH v3 11/11] net: sched: change action API to use array of pointers to actions

2018-05-27 Thread Vlad Buslov
Act API used linked list to pass set of actions to functions. It is intrusive data structure that stores list nodes inside action structure itself, which means it is not safe to modify such list concurrently. However, action API doesn't use any linked list specific operations on this set of