RE: [PATCH v3 11/18] qlcnic: Eliminate duplicate barriers on weakly-ordered archs

2018-03-19 Thread Chopra, Manish
gt; Sinan Kaya <ok...@codeaurora.org>; Patil, Harish <harish.pa...@cavium.com>; > Chopra, Manish <manish.cho...@cavium.com>; Dept-GE Linux NIC Dev gelinuxnic...@cavium.com>; linux-ker...@vger.kernel.org > Subject: [PATCH v3 11/18] qlcnic: Eliminate duplicate barriers on > weakly-o

[PATCH v3 11/18] qlcnic: Eliminate duplicate barriers on weakly-ordered archs

2018-03-16 Thread Sinan Kaya
Code includes wmb() followed by writel(). writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_relaxed().