Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-27 Thread Stephen Hemminger
> + > +static struct ethtool_ops nb8800_ethtool_ops = { Ops should be const > + .get_settings = nb8800_get_settings, > + .set_settings = nb8800_set_settings, > + .nway_reset = nb8800_nway_reset, > + .get_link = ethtool_op_get_link, >

Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-27 Thread Måns Rullgård
Stephen Hemminger writes: >> +.get_settings = nb8800_get_settings, >> +.set_settings = nb8800_set_settings, >> +.nway_reset = nb8800_nway_reset, >> +.get_link = ethtool_op_get_link, >> +}; >> + > > Since

[PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-26 Thread Mans Rullgard
This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - remove check for wake on lan irq as it is never requested - prettify mac