Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-07 Thread Måns Rullgård
Sebastian Frias writes: > Hi Måns, > > On 11/05/2016 01:58 PM, Måns Rullgård wrote: >>> if (gigabit) { >>> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII) >>> + if (phy_interface_is_rgmii(phydev)) >>> mac_mode |= RGMII_MODE; >>> >>>

Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-07 Thread Sebastian Frias
Hi Måns, On 11/05/2016 01:58 PM, Måns Rullgård wrote: >> if (gigabit) { >> -if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII) >> +if (phy_interface_is_rgmii(phydev)) >> mac_mode |= RGMII_MODE; >> >> mac_mode |= GMAC_MODE; > > As I said

Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-05 Thread Måns Rullgård
Sebastian Frias writes: > Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") > and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal > delay for tx and rx only") added several RGMII definitions: > PHY_INTERFACE_MODE_RGMII_ID,

[PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Sebastian Frias
Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal delay for tx and rx only") added several RGMII definitions: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and PHY_INTERFACE_MODE_RGMII_TXID to