Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

On Mon, 2 Apr 2018 07:43:49 + Alexander Kurz wrote: > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 > ++--- > 1 file

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

[dropping Freddy as I'm getting bounces from asix.com.tw] On Mon, 2 Apr 2018 15:21:08 + Alexander Kurz wrote: Alexander, > Hi Marc, David, > with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") > I made an embarrasly stupid mistake of removing the wrong

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

Hi Marc, David, with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") I made an embarrasly stupid mistake of removing the wrong function. The v2 patch accidentially changed ax88179_link_reset() instead of ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate code")

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

From: Marc Zyngier Date: Mon, 02 Apr 2018 10:45:40 +0100 > What has changed between this patch and the previous one? Having a bit > of a change-log would certainly help. Also, I would have appreciated a > reply to the questions I had on v2 before you posted a third version.

Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

On Mon, 02 Apr 2018 08:43:49 +0100, Alexander Kurz wrote: Alexander, > > Remove the duplicated code for asix88179_178a bind and reset methods. > > Signed-off-by: Alexander Kurz > --- > drivers/net/usb/ax88179_178a.c | 137 > ++--- > 1 file

[PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 137 ++--- 1 file changed, 31 insertions(+), 106 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c