Re: [PATCH v3 net-next] rtnetlink: bridge: use ext_ack instead of printk

2017-10-10 Thread David Ahern
On 10/10/17 8:44 AM, Florian Westphal wrote: > @@ -3666,7 +3666,7 @@ static int rtnl_bridge_setlink(struct sk_buff *skb, > struct nlmsghdr *nlh, > > dev = __dev_get_by_index(net, ifm->ifi_index); > if (!dev) { > - pr_info("PF_BRIDGE: RTM_SETLINK with unknown ifindex\n");

[PATCH v3 net-next] rtnetlink: bridge: use ext_ack instead of printk

2017-10-10 Thread Florian Westphal
We can now piggyback error strings to userspace via extended acks rather than using printk. Before: bridge fdb add 01:02:03:04:05:06 dev br0 vlan 4095 RTNETLINK answers: Invalid argument After: bridge fdb add 01:02:03:04:05:06 dev br0 vlan 4095 Error: invalid vlan id. v3: drop 'RTM_' prefixes,