Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Scott Feldman
On Wed, May 20, 2015 at 3:32 PM, Simon Horman wrote: > > On Wed, May 20, 2015 at 10:37:52AM -0700, Scott Feldman wrote: > > On Wed, May 20, 2015 at 5:57 AM, Simon Horman > > wrote: > > > On Wed, May 20, 2015 at 01:17:36PM +0200, Jiri Pirko wrote: > > >> Wed, May 20, 2015 at 10:46:26AM CEST, simon

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 10:37:52AM -0700, Scott Feldman wrote: > On Wed, May 20, 2015 at 5:57 AM, Simon Horman > wrote: > > On Wed, May 20, 2015 at 01:17:36PM +0200, Jiri Pirko wrote: > >> Wed, May 20, 2015 at 10:46:26AM CEST, simon.hor...@netronome.com wrote: > >> >On Wed, May 20, 2015 at 05:36:0

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Scott Feldman
On Wed, May 20, 2015 at 5:57 AM, Simon Horman wrote: > On Wed, May 20, 2015 at 01:17:36PM +0200, Jiri Pirko wrote: >> Wed, May 20, 2015 at 10:46:26AM CEST, simon.hor...@netronome.com wrote: >> >On Wed, May 20, 2015 at 05:36:06PM +0900, Toshiaki Makita wrote: >> >> On 2015/05/20 16:48, Simon Horman

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Jiri Pirko
Wed, May 20, 2015 at 10:46:26AM CEST, simon.hor...@netronome.com wrote: >On Wed, May 20, 2015 at 05:36:06PM +0900, Toshiaki Makita wrote: >> On 2015/05/20 16:48, Simon Horman wrote: >> > On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: >> >> On 2015/05/20 14:48, Simon Horman wrote:

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 05:36:06PM +0900, Toshiaki Makita wrote: > On 2015/05/20 16:48, Simon Horman wrote: > > On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: > >> On 2015/05/20 14:48, Simon Horman wrote: > ... > >>> static void _rocker_neigh_add(struct rocker *rocker, > >>> +

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Toshiaki Makita
On 2015/05/20 16:48, Simon Horman wrote: > On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: >> On 2015/05/20 14:48, Simon Horman wrote: ... >>> static void _rocker_neigh_add(struct rocker *rocker, >>> + enum switchdev_trans trans, >>>

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-20 Thread Simon Horman
On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote: > On 2015/05/20 14:48, Simon Horman wrote: > > rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be > > be called with trans == SWITCHDEV_TRANS_PREPARE and then > > trans == SWITCHDEV_TRANS_COMMIT from switchdev_port_obj_

Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-19 Thread Jiri Pirko
Wed, May 20, 2015 at 07:48:21AM CEST, simon.hor...@netronome.com wrote: >rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be >be called with trans == SWITCHDEV_TRANS_PREPARE and then >trans == SWITCHDEV_TRANS_COMMIT from switchdev_port_obj_set() via >fib_table_insert(). > >The first t