Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-04-04 Thread Neal Cardwell
On Wed, Apr 4, 2018 at 6:42 AM Ilpo Järvinen wrote: > On Wed, 28 Mar 2018, Yuchung Cheng wrote: ... > > Your patch looks good. Some questions / comments: The patch looks good to me as well (I read the Mar 28 version). Thanks for this fix, Ilpo. > Just to be sure that we understand each other th

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-04-04 Thread Ilpo Järvinen
On Wed, 28 Mar 2018, Yuchung Cheng wrote: > On Wed, Mar 28, 2018 at 7:14 AM, Yuchung Cheng wrote: > > > > On Wed, Mar 28, 2018 at 5:45 AM, Ilpo Järvinen > > wrote: > > > On Tue, 27 Mar 2018, Yuchung Cheng wrote: > > > > > >> On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen > > >> wrote: > > >> >

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-28 Thread Yuchung Cheng
On Wed, Mar 28, 2018 at 7:14 AM, Yuchung Cheng wrote: > > On Wed, Mar 28, 2018 at 5:45 AM, Ilpo Järvinen > wrote: > > On Tue, 27 Mar 2018, Yuchung Cheng wrote: > > > >> On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen > >> wrote: > >> > On Mon, 26 Mar 2018, Yuchung Cheng wrote: > >> > > >> >> On T

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-28 Thread Yuchung Cheng
On Wed, Mar 28, 2018 at 5:45 AM, Ilpo Järvinen wrote: > On Tue, 27 Mar 2018, Yuchung Cheng wrote: > >> On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen >> wrote: >> > On Mon, 26 Mar 2018, Yuchung Cheng wrote: >> > >> >> On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen >> >> wrote: >> >> > >> >> > A

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-28 Thread Ilpo Järvinen
On Tue, 27 Mar 2018, Yuchung Cheng wrote: > On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen > wrote: > > On Mon, 26 Mar 2018, Yuchung Cheng wrote: > > > >> On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > >> wrote: > >> > > >> > A miscalculation for the number of acknowledged packets occurs durin

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-27 Thread Yuchung Cheng
On Tue, Mar 27, 2018 at 7:23 AM, Ilpo Järvinen wrote: > On Mon, 26 Mar 2018, Yuchung Cheng wrote: > >> On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen >> wrote: >> > >> > A miscalculation for the number of acknowledged packets occurs during >> > RTO recovery whenever SACK is not enabled and a cumu

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-27 Thread Ilpo Järvinen
On Mon, 26 Mar 2018, Yuchung Cheng wrote: > On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen > wrote: > > > > A miscalculation for the number of acknowledged packets occurs during > > RTO recovery whenever SACK is not enabled and a cumulative ACK covers > > any non-retransmitted skbs. The reason is

Re: [PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-26 Thread Yuchung Cheng
On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > > A miscalculation for the number of acknowledged packets occurs during > RTO recovery whenever SACK is not enabled and a cumulative ACK covers > any non-retransmitted skbs. The reason is that pkts_acked value > calculated in tcp_clean_rtx_qu

[PATCH v3 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

2018-03-13 Thread Ilpo Järvinen
A miscalculation for the number of acknowledged packets occurs during RTO recovery whenever SACK is not enabled and a cumulative ACK covers any non-retransmitted skbs. The reason is that pkts_acked value calculated in tcp_clean_rtx_queue is not correct for slow start after RTO as it may include seg