Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-26 Thread 严海双
> On 2017年9月27日, at 上午2:18, David Miller wrote: > > From: 严海双 > Date: Tue, 26 Sep 2017 09:25:51 +0800 > >>> On 2017年9月26日, at 上午7:24, David Miller wrote: >>> >>> From: Haishuang Yan

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-26 Thread David Miller
From: 严海双 Date: Tue, 26 Sep 2017 09:25:51 +0800 >> On 2017年9月26日, at 上午7:24, David Miller wrote: >> >> From: Haishuang Yan >> Date: Fri, 22 Sep 2017 21:48:43 +0800 >> >>> @@ -9,13 +9,18 @@ >>> #include

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-25 Thread 严海双
> On 2017年9月26日, at 上午7:24, David Miller wrote: > > From: Haishuang Yan > Date: Fri, 22 Sep 2017 21:48:43 +0800 > >> @@ -9,13 +9,18 @@ >> #include >> #include >> >> -struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; >> - >>

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-25 Thread David Miller
From: Haishuang Yan Date: Fri, 22 Sep 2017 21:48:43 +0800 > @@ -9,13 +9,18 @@ > #include > #include > > -struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; > - > -static DEFINE_SPINLOCK(tcp_fastopen_ctx_lock); > - > -void tcp_fastopen_init_key_once(bool

[PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-22 Thread Haishuang Yan
Different namespace application might require different tcp_fastopen_key independently of the host. David Miller pointed out there is a leak without releasing the context of tcp_fastopen_key during netns teardown. So add the release action in exit_batch path. Tested: 1. Container namespace: #