Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-20 Thread Andrew Lunn
On Fri, Jan 20, 2017 at 12:30:16PM -0500, Vivien Didelot wrote: > Hi Gregory, > > Gregory CLEMENT writes: > > > If there a series about to be merged I can rebase my series on it. Else > > I propose to keep it and convert the family check to ops when you will

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-20 Thread Vivien Didelot
Hi Gregory, Gregory CLEMENT writes: > If there a series about to be merged I can rebase my series on it. Else > I propose to keep it and convert the family check to ops when you will > send the series for it. I am reworking the VTU operations, but not these

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-20 Thread Gregory CLEMENT
Hi Vvien and Andrew, On ven., janv. 20 2017, Andrew Lunn wrote: > On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote: >> Gregory CLEMENT writes: >> >> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip) >> > +{ >>

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 (fwd)

2017-01-20 Thread Julia Lawall
/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 In-Reply-To: <20170119214934.27442-3-gregory.clem...@free-electrons.com> Hi Gregory, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170120] [cannot apply to v4.10-rc4] [if your patch is applie

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell >> family of switch chips? > > My understand is that it is. Marvell have not added it to DSDT. There > is a new SDK called UMSD, also GPLv2 and BSD. They call this family >

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Andrew Lunn
On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote: > Gregory CLEMENT writes: > > > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip) > > +{ > > + return chip->info->family == MV88E6XXX_FAMILY_6341; > > +} > > I don't want to see

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Vivien Didelot
Gregory CLEMENT writes: > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip) > +{ > + return chip->info->family == MV88E6XXX_FAMILY_6341; > +} I don't want to see these erronous family checks anymore, but I cannot blame you for adding it

[PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Gregory CLEMENT
The Marvell 88E6341 device is single-chip, 6-port Ethernet switch with four integrated 10/100/1000Mbps Ethernet transceivers and one high speed SerDes interfaces. It is partially compatible with switches of family 88E6352 and switches of family 88E6390. This commit adds an initial support for