Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: > Mason writes: > >> On 25/11/2015 13:45, Måns Rullgård wrote: >> >>> Mason wrote: >>> On 19/11/2015 14:02, Mans Rullgard wrote: > + if (dma_mapping_error(>dev, dma_addr)) { > +

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Alexander Duyck writes: > On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >> Mason writes: >> >>> On 25/11/2015 13:45, Måns Rullgård wrote: >>> Mason wrote: > On 19/11/2015 14:02, Mans Rullgard wrote: >

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Mason writes: > On 25/11/2015 17:16, Måns Rullgård wrote: > >> Alexander Duyck writes: >> >>> On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >>> Mason writes: > On 25/11/2015 13:45, Måns Rullgård wrote: > >> Mason wrote: >> >>> On

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Mason
On 25/11/2015 17:16, Måns Rullgård wrote: > Alexander Duyck writes: > >> On Wed, Nov 25, 2015 at 5:04 AM, Måns Rullgård wrote: >> >>> Mason writes: >>> On 25/11/2015 13:45, Måns Rullgård wrote: > Mason wrote: > >> On 19/11/2015 14:02, Mans Rullgard wrote: >> >>> +

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Mason
On 19/11/2015 14:02, Mans Rullgard wrote: > + if (dma_mapping_error(>dev, dma_addr)) { > + skb_free_frag(data); > + return -ENOMEM; > + } I'm back-porting this driver to 4.1 skb_free_frag() was introduced in 4.2 by 181edb2bfa22b IIUC. +static inline void

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Mason writes: > On 19/11/2015 14:02, Mans Rullgard wrote: > >> +if (dma_mapping_error(>dev, dma_addr)) { >> +skb_free_frag(data); >> +return -ENOMEM; >> +} > > I'm back-porting this driver to 4.1 > > skb_free_frag() was introduced in 4.2 by

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Mason
[ Using different address for Alexander ] On 25/11/2015 13:36, Mason wrote: > On 19/11/2015 14:02, Mans Rullgard wrote: > >> +if (dma_mapping_error(>dev, dma_addr)) { >> +skb_free_frag(data); >> +return -ENOMEM; >> +} > > I'm back-porting this driver to 4.1 > >

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Mason
On 25/11/2015 13:45, Måns Rullgård wrote: > Mason wrote: > >> On 19/11/2015 14:02, Mans Rullgard wrote: >> >>> + if (dma_mapping_error(>dev, dma_addr)) { >>> + skb_free_frag(data); >>> + return -ENOMEM; >>> + } >> >> I'm back-porting this driver to 4.1 >> >>

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-25 Thread Måns Rullgård
Mason writes: > On 25/11/2015 13:45, Måns Rullgård wrote: > >> Mason wrote: >> >>> On 19/11/2015 14:02, Mans Rullgard wrote: >>> + if (dma_mapping_error(>dev, dma_addr)) { + skb_free_frag(data); + return -ENOMEM; + } >>> >>> I'm

Re: [PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-20 Thread David Miller
From: Mans Rullgard Date: Thu, 19 Nov 2015 13:02:59 + > This adds a driver for the Aurora VLSI NB8800 Ethernet controller. > It is an almost complete rewrite of a driver originally found in > a Sigma Designs 2.6.22 tree. > > Signed-off-by: Mans Rullgard

[PATCH v8] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-11-19 Thread Mans Rullgard
This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - make some variables unsigned --- drivers/net/ethernet/Kconfig |